Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository Handler - always choose the same entity for latest when dates are equal #6887

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Repository Handler - always choose the same entity for latest when dates are equal #6887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...c/main/java/org/odpi/openmetadata/commonservices/repositoryhandler/RepositoryHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,8 @@ else if (errorHandler.validateIsLatestUpdate(existingClassification, peerClassif

/**
* Use the dates in the entities and return the one that was last updated most recently.
* If the dates are equal, then compare GUIDs in order to always retrieve the same entity (no matter
* which of the is the current and which is the new one).
*
* @param currentEntity current entity
* @param newEntity next peer entity
Expand All @@ -317,6 +319,18 @@ private EntityDetail getLatest(EntityDetail currentEntity, EntityDetail newEntit
newLastUpdate = newEntity.getCreateTime();
}

if(currentLastUpdate.equals(newLastUpdate))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaUtilDate: Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UndefinedEquals: Date does not have well-defined equals behavior.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

{
if(currentEntity.getGUID().compareTo(newEntity.getGUID()) >= 0)
{
return currentEntity;
}
else
{
return newEntity;
}
}

if (currentLastUpdate.before(newLastUpdate))
{
return new EntityDetail(newEntity);
Expand Down