ignore some dirty schema in tidb (pingcap#35)

Co-authored-by: 3pointer <[email protected]>
okJiang · Mar 5, 2020 · be707a3 · be707a3
1 parent 5b532ab
commit be707a3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/v4/export/dump.go b/v4/export/dump.go
@@ -29,6 +29,7 @@ func Dump(conf *Config) (err error) {
 	if err != nil {
 		return err
 	}
+
 	if !conf.NoViews {
 		views, err := listAllViews(pool, databases)
 		if err != nil {
@@ -37,6 +38,8 @@ func Dump(conf *Config) (err error) {
 		conf.Tables.Merge(views)
 	}
 
+	filterDirtySchemaTables(conf)
+
 	conCtrl, err := NewConsistencyController(conf, pool)
 	if err != nil {
 		return err

diff --git a/v4/export/prepare.go b/v4/export/prepare.go
@@ -5,6 +5,7 @@ import (
 	"strings"
 
 	"github.com/pingcap/dumpling/v4/log"
+	"go.uber.org/zap"
 )
 
 func detectServerInfo(db *sql.DB) (ServerInfo, error) {
@@ -92,3 +93,16 @@ func (d DatabaseTables) Merge(other DatabaseTables) {
 		d[name] = append(d[name], infos...)
 	}
 }
+
+func filterDirtySchemaTables(conf *Config) {
+	switch conf.ServerInfo.ServerType {
+	case ServerTypeTiDB:
+		for dbName := range conf.Tables {
+			switch strings.ToUpper(dbName) {
+			case "INSPECTION_SCHEMA", "METRICS_SCHEMA", "PERFORMANCE_SCHEMA", "INFORMATION_SCHEMA":
+				log.Zap().Warn("unsupported dump schema in TiDB now", zap.String("schema", dbName))
+				delete(conf.Tables, dbName)
+			}
+		}
+	}
+}