Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup compare #35

Merged
merged 4 commits into from
Sep 7, 2015
Merged

cleanup compare #35

merged 4 commits into from
Sep 7, 2015

Conversation

siddontang
Copy link
Member

binary comparison and types.Compare nearly do the same thing, and at same time, types.Compare lacks
multi different types comparison, so I use binary comparison uniformly.

  • move binary comparison to implement new types.Compare
  • types.Compare returns error instead of panic

@ngaut
Copy link
Member

ngaut commented Sep 7, 2015

LGTM

1 similar comment
@shenli
Copy link
Member

shenli commented Sep 7, 2015

LGTM

ngaut added a commit that referenced this pull request Sep 7, 2015
@ngaut
Merge pull request #35 from pingcap/siddontang/cleanup-compare
6b0dce0 
cleanup compare
@ngaut ngaut merged commit 6b0dce0 into master Sep 7, 2015
@ngaut ngaut deleted the siddontang/cleanup-compare branch September 7, 2015 06:04
spongedu added a commit to spongedu/tidb that referenced this pull request Oct 26, 2019
@spongedu @qiuyesuifeng
complete log reader (pingcap#35)
576417b 
* Support local_log_reader && remote_log_reader

* support predicate push down to log reader

* refine log names

* refine http log handler

* specific host to read log

* 1. support multi-node log-reader 2. support uniform tikv-tidb log reader

* finding log path from global config

* bug fix
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@huachaohuang
Import all data into TiKV before updating auto id (pingcap#35)
73be442
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@3pointer @overvenus
update tidb-tools dependency (pingcap#35)
2646a49
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
@tiancaiamao @jackysp
[parser] README: add Go Report Card and CircleCI Status badge (pi…
dc040fa 
…ngcap#35)
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
@tiancaiamao @xhebox
[parser] README: add Go Report Card and CircleCI Status badge (pi…
0e8df89 
…ngcap#35)
ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021
@tiancaiamao @ti-chi-bot
[parser] README: add Go Report Card and CircleCI Status badge (#35)
027ca88
okJiang pushed a commit to okJiang/tidb that referenced this pull request Oct 19, 2021
@3pointer
ignore some dirty schema in tidb (pingcap#35)
be707a3 
Co-authored-by: 3pointer <[email protected]>
Defined2014 pushed a commit to Defined2014/tidb that referenced this pull request Apr 11, 2022
@tangenta
ddl: add some tests for drop columns/indexes (pingcap#35)
aadf31f
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Oct 31, 2022
@ystaticy
update etcd namespace by keyspace prefix (pingcap#35)
910a86e 
* update etcd namespace by keyspace prefix

Signed-off-by: ystaticy <[email protected]>
rleungx pushed a commit to rleungx/tidb that referenced this pull request Feb 26, 2024
@clark1013 @lcwangchao
@CbcWestwolf @ti-chi-bot @wuhuizuo @zeminzhou @baiyuqing
extension/serverless: introduce serverless audit log (pingcap#870)
aef4fc1 
* init

* audit: init first version of audit log

* audit: support log global rotate

* audit: update log keys

* audit: more common notify implement

* audit: add record id

* audit: rename some names

* audit: default use normal log path

* audit: add server ip info

* audit: do some refine

* audit: Add some log keys

* audit: update some item format

* audit: add stmt demo

* audit: support redact

* audit: fix bug

* audit: update filter

* audit: update filter

* audit: check user

* audit: update

* update

* audit: update

* audit: fix bug

* aduit: update

* audit: update

* update

* update

* audit: add filter unit test

* fmt

* Add tests for `tidb_audit_enabled` and `tidb_audit_log`

* Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime`

* Add tests for `tidb_audit_log_reserved_*`

* TODO: TestAuditLogRedact

* Fininsh `TestAuditLogRedact`

* Update (pingcap#1)

* fix typo (pingcap#2)

* Add `TRANSACTION`

* rename sysvar

* audit_log_create_filter, audit_log_remove_filter

* finish function call and table test

* test privilege

* finish test for sysvar

* TODO: TestConnectionEvenClass

* update

* audit: fix lint for audit log (pingcap#1)

* audit: fix UT failure caused by the change of redact log (pingcap#3)

* audit: use `t.TempDir()` to make test stable (pingcap#4)

* audit: fix test failed for 7.1

* Add `OWNERS` file (pingcap#35)

Co-authored-by: Chao Wang <[email protected]>

* audit: fix panic when logging sometime (pingcap#26) (pingcap#31)

* test: fix unstable test TestAuditLogReservedDays (pingcap#8)

* Format sysvar_test.go

* audit: use `StatementContext` to generate redacted SQL (pingcap#9)

* audit: fix panic when logging sometime (pingcap#26)

* update

* add owner

* Update OWNERS

---------

Co-authored-by: CbcWestwolf <[email protected]>
Co-authored-by: wuhuizuo <[email protected]>

* audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39)

* This is an automated cherry-pick of pingcap#37

Signed-off-by: ti-chi-bot <[email protected]>

* fix conflict

---------

Signed-off-by: ti-chi-bot <[email protected]>
Co-authored-by: 王超 <[email protected]>

* extension/audit: introduce serverless audit log

Signed-off-by: Wen Jiazhi <[email protected]>

* update bazel config

Signed-off-by: Wen Jiazhi <[email protected]>

* support enable audit log when activate

Signed-off-by: Wen Jiazhi <[email protected]>

* add gwconnid to audit log

Signed-off-by: Wen Jiazhi <[email protected]>

* comment unstable test

* update bazel

* add log about activate request

* diff audit log enabled

* audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45)

* This is an automated cherry-pick of pingcap#44

Signed-off-by: ti-chi-bot <[email protected]>

* Update util.go

---------

Signed-off-by: ti-chi-bot <[email protected]>
Co-authored-by: 王超 <[email protected]>

* Update extension/serverless/OWNERS

---------

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Wen Jiazhi <[email protected]>
Co-authored-by: Chao Wang <[email protected]>
Co-authored-by: cbcwestwolf <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Co-authored-by: wuhuizuo <[email protected]>
Co-authored-by: zzm <[email protected]>
Co-authored-by: Yuqing Bai <[email protected]>
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@mittalrishabh
add retry if transaction failed while fetching task metas (pingcap#35)
23b557e 
Co-authored-by: rishabh_mittal <[email protected]>
mittalrishabh added a commit to mittalrishabh/tidb that referenced this pull request May 6, 2024
@mittalrishabh
add retry if transaction failed while fetching task metas (pingcap#35)
a431738 
Co-authored-by: rishabh_mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddontang @ngaut @shenli