Add network.mode configuration option for buildkit service #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Lopez <[email protected]>
jLopezbarb
requested review from
codyjlandstrom,
pchico83,
ifbyol and
rlamana
as code owners
✅ Deploy Preview for okteto-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pchico83
approved these changes
Sep 4, 2024
Merged
| @@ -209,7 +209,7 @@ The build service. It's used in combination with `okteto build` to build contain | |||
| - `persistence.cache`: The size (in Mi) of the buildkit cache to store image caches. It should be around 30Gi smaller than `storage.size`. Defaults to 500Gi. | |||
| - `tolerations`: List of tolerations to be added to the buildkit service Pods. This list of tolerations will be applied in conjunction with any tolerations set in [`tolerations.buildPool`](self-hosted/helm-configuration.mdx#tolerations) until deprecation of `tolerations.buildPool`. If not set, the buildkit Pods will inherit the tolerations list set in [`globals.tolerations.okteto`](self-hosted/helm-configuration.mdx#globals). | |||
| - `nodeSelectors`: Dictionary of node selectors to be added to the buildkit service Pods. This helps you match Pods to nodes whose labels match the node selector. This list of node selectors will be applied in conjunction with the node selectors set by [`tolerations.buildPool`](self-hosted/helm-configuration.mdx#tolerations) until deprecation of `tolerations.buildPool`. If not set, the buildkit Pods will inherit the node selectors dictionary set in [`globals.nodeSelectors.okteto`](self-hosted/helm-configuration.mdx#globals). | |||
| - `network.mode`: Controls the networking environment for containers during the build process. Defaults to `auto` but can be set to `host`, `none`, or `bridge`. Bridge mode allows you to control which stages of a multi-stage Docker build have access to the network. This can be useful in complex build environments where security, efficiency, and consistency are priorities | |||
| - `network.mode`: Controls the networking environment for containers during the build process. Defaults to `auto` but can be set to `host`, `none`, or `bridge`. Bridge mode can be useful for preventing port collisions in concurrent builds by isolating network environments. | |||
There was a problem hiding this comment.
@pchico83 Does this update sound ok?
codyjlandstrom
added a commit
that referenced
this pull request
Sep 6, 2024
* add 1.24 release notes * add note about developer quickstart guide * start to address PR feedback * Add network.mode configuration option for buildkit service (#819) * feat: Add network.mode configuration option for buildkit service Signed-off-by: Javier Lopez <[email protected]> * add explaination on bridge mode * fix details on bridge mode --------- Signed-off-by: Javier Lopez <[email protected]> Co-authored-by: Cody Landstrom <[email protected]> * add 1.24 release notes * add note about developer quickstart guide * start to address PR feedback * addressing more pr feedback * additional PR feedback * clean up last pr feedback --------- Signed-off-by: Javier Lopez <[email protected]> Co-authored-by: Cody Landstrom <[email protected]> Co-authored-by: Javier López Barba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new configuration option,
network.mode, for the buildkit service. This option controls the networking environment for containers during the build process and can be set toauto,host,none, orbridge.