Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported node: ConditionalExpression & LogicalExpression #39

Closed
hjylewis opened this issue Feb 28, 2018 · 4 comments · Fixed by #43
Closed

Unsupported node: ConditionalExpression & LogicalExpression #39

hjylewis opened this issue Feb 28, 2018 · 4 comments · Fixed by #43
Labels
enhancement

Comments

@hjylewis
Copy link

hjylewis commented Feb 28, 2018 •
edited
Loading

There isn't support for instances of:

  • extractFromCode("i18n(cond && 'im conditional')")
  • extractFromCode("i18n(cat ? 'cat' : 'not cat')")

getKey should at least return '*'
@hjylewis hjylewis changed the title Unsupported node: ConditionalExpression & Unsupported node: LogicalExpression Unsupported node: ConditionalExpression & LogicalExpression Feb 28, 2018
gsouf added a commit to gsouf/i18n-extract that referenced this issue Jun 2, 2018
@gsouf
Add support for ternary expression
9b088fb 
oliviertassinari#39
gsouf added a commit to gsouf/i18n-extract that referenced this issue Jun 2, 2018
@gsouf
Add support for logical expressions
1393076 
oliviertassinari#39
@gsouf gsouf mentioned this issue Jun 2, 2018
Merged
gsouf added a commit to gsouf/i18n-extract that referenced this issue Jun 2, 2018
@gsouf
Add support for logical expressions
552be11 
oliviertassinari#39
@gsouf
Copy link
Contributor

gsouf commented Jun 4, 2018

Hi @oliviertassinari can you, please, let us know if you plan to fix this issue?

@oliviertassinari
Copy link
Owner

oliviertassinari commented Jun 4, 2018 •
edited
Loading

@gsouf I don't plan on working on this issue. But it seems you started working on adding such support :).

@gsouf
Copy link
Contributor

gsouf commented Jun 4, 2018

Ok, so it's maybe better just close the issue and let people know about your intention

@gsouf
Copy link
Contributor

gsouf commented Jun 4, 2018

Just saw your edit, nevermind about the previous message then

oliviertassinari pushed a commit that referenced this issue Jun 4, 2018
@gsouf @oliviertassinari
Add support for ternary operator and logical expressions (#43)
c6f69cc 
* Add support for ternary expression
#39

* added nested test for ternary operator

* Add support for logical expressions
#39

* fixed eslint
@oliviertassinari oliviertassinari mentioned this issue Aug 6, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for ternary operator and logical expressions gsouf/i18n-extract
3 participants
@oliviertassinari @gsouf @hjylewis