Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ternary operator and logical expressions #43

Merged
merged 4 commits into from
Jun 4, 2018

Conversation

gsouf
Copy link
Contributor

@gsouf gsouf commented Jun 2, 2018

Hi,

This fix makes the getKey to be replaced with getKeys that is now able to return multiple keys at once. That way we can add support for logical expressions and ternary operators that required the ability to return multiple keys.

Fix #39

@gsouf gsouf changed the title Add support for ternary operator and logical expressions to fix #39 Add support for ternary operator and logical expressions Jun 2, 2018
@gsouf
Copy link
Contributor Author

gsouf commented Jun 4, 2018

Closing as maintainer doesnt plan to get this fixed.

@gsouf gsouf closed this Jun 4, 2018
@gsouf
Copy link
Contributor Author

gsouf commented Jun 4, 2018

@oliviertassinari concerning travis failing for some reasons the eslints does not run the same way on my computer and on travis, getting it fixed to match travis way

@oliviertassinari oliviertassinari merged commit c6f69cc into oliviertassinari:master Jun 4, 2018
@oliviertassinari
Copy link
Owner

@gsouf Thanks

@gsouf
Copy link
Contributor Author

gsouf commented Jun 4, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported node: ConditionalExpression & LogicalExpression
2 participants