Check datasets shape and dtype #16
Conversation
✅ Deploy Preview for ome-ngff-validator ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
will-moore
force-pushed
the
dataset_array_checks
branch
from
b9153f8
to
a22aa14
Compare
|
Nice, @will-moore! I got some "Error loading" messages from the URLs above. Also: it might be worth considering how we maintain multiple validators for these non-json-schema constraints. Would defining "rule numbers" for each of them be feasible/useful? |
As expected! The "Error loading" is what you get if you use an invalid version, since we use the version to construct the schema URL. We don't try to maintain a list of all valid versions in this tool. I guess we could try to handle that 404 with a more custom message. Other errors for the other test URL are also expected (violations of rules 1, 2, 3 & 4. |
|
For me, "error loading" meant something like "the data is not accessible". 👍 for "incompatible version: ${version}", etc. |
|
@joshmoore: better? Sorry, wrong image - this is the right one... |
|
I like it! Thanks. One last thing: did the file for "4: dtype mismatch" get deleted? |
|
Hmmm - not sure why that got deleted. But here's another with the same dtype issue: |
This PR validates a few things that aren't checked by the schema validation:
/when version is 0.2-0.4To test:
NB: This currently asserts that the dtypes are all equal for
v0.4(so this PR can be tested). Need to revert to testingv0.5and above BEFORE merging!For other tests above, we really need some invalid sample data available... Might try to make some...
cc @constantinpape