Fix versions for dtype checks. Don't check v0.4 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ome-ngff-validator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks, @will-moore. MSTM. I assume it's considerably more work, but do you think it would be possible to get an informational message that this would cause an error/warning in the next version? |
will-moore
force-pushed
the
fix_dtypes_check_versions
branch
from
f005947
to
4acfaaa
Compare
|
@joshmoore https://deploy-preview-18--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.4/idr0077/9836832_z.zarr It will look like this with But for versions 0.1 - 0.4 you'll just see it as a warning: |
|
Wow, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad: For #16 (comment) the validator checks dtypes for v0.4 NGFF and asserts failure if dtypes mismatch (so that the PR could be tested).
However, v0.4 NGFF with mismatching dtypes are not actually invalid.
I forgot to revert that change before merging. So this PR fixes that and ONLY asserts that mismatching dtypes are invalid for versions after v0.4, to correspond to ome/ngff#154
So, checking the mismatching dytpe sample from the PR above (v0.4) should no-longer give a warning:
https://deploy-preview-18--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.4/idr0077/9836832_z.zarr