Skip to content

Commit

Permalink
Merge pull request #1728 from onaio/1726-xform-version-return-non-digit
Browse files Browse the repository at this point in the history
Return XForm version even if the version is not a number
  • Loading branch information
ukanga committed Nov 27, 2019
2 parents 5fe1f79 + 335bacf commit a27e923
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions onadata/libs/serializers/xform_serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,17 +356,12 @@ def get_has_id_string_changed(self, obj):
class XFormListSerializer(serializers.Serializer):
formID = serializers.ReadOnlyField(source='id_string')
name = serializers.ReadOnlyField(source='title')
version = serializers.SerializerMethodField()
version = serializers.ReadOnlyField()
hash = serializers.ReadOnlyField()
descriptionText = serializers.ReadOnlyField(source='description')
downloadUrl = serializers.SerializerMethodField('get_url')
manifestUrl = serializers.SerializerMethodField('get_manifest_url')

@check_obj
def get_version(self, obj):
if obj.version and obj.version.isdigit():
return obj.version

@check_obj
def get_url(self, obj):
kwargs = {'pk': obj.pk, 'username': obj.user.username}
Expand Down

0 comments on commit a27e923

Please sign in to comment.