Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return XForm version even if the version is not a number #1728

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Return XForm version even if the version is not a number #1728

merged 1 commit into from
Nov 27, 2019

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Nov 25, 2019 •
edited
Loading

Changes

  • Removed get_version function

Fixes #1726

@DavisRayM
Remove get_version function
335bacf 
- Return all version irrespective of whether version is non digit
@ukanga ukanga merged commit a27e923 into master Nov 27, 2019
@ukanga ukanga deleted the 1726-xform-version-return-non-digit branch November 27, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

@ivermac ivermac ivermac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return XForm versions even if the version is not a number
3 participants
@DavisRayM @ukanga @ivermac