Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return XForm versions even if the version is not a number #1726

Closed
DavisRayM opened this issue Nov 22, 2019 · 2 comments · Fixed by #1728
Closed

Return XForm versions even if the version is not a number #1726

DavisRayM opened this issue Nov 22, 2019 · 2 comments · Fixed by #1728
Assignees
@DavisRayM
Labels
Discussion
Milestone
Week39-40(2019)

Comments

@DavisRayM
Copy link
Contributor

DavisRayM commented Nov 22, 2019 •
edited by imkingrobi
Loading

We are currently not returning XForm versions if the version is not a digit. Which ends up breaking exports through ODK Briefcase for KPI built forms.

Aha! Link: https://ona.aha.io/features/PROD-198
@DavisRayM DavisRayM self-assigned this Nov 22, 2019
DavisRayM added a commit that referenced this issue Nov 22, 2019
@DavisRayM
Revert removal of get_version function
c6eb1c9 
- Separate issue opened to deal with this change #1726
DavisRayM added a commit that referenced this issue Nov 22, 2019
@DavisRayM
Revert removal of get_version function
a38b783 
- Separate issue opened to deal with this change #1726
DavisRayM added a commit that referenced this issue Nov 22, 2019
@DavisRayM
Revert removal of get_version function
2487998 
- Separate issue opened to deal with this change #1726
- Fix failing tests
@DavisRayM
Copy link
Contributor Author

This issue clashes with #982

@WinnyTroy WinnyTroy added this to the Week39-40(2019) milestone Nov 25, 2019
DavisRayM added a commit that referenced this issue Nov 25, 2019
@DavisRayM
Revert removal of get_version function
f6056d2 
- Separate issue opened to deal with this change #1726
- Fix failing tests
@DavisRayM DavisRayM mentioned this issue Nov 26, 2019
Closed
@ggalmazor
Copy link

Thanks for documenting this issue, @DavisRayM.

Indeed, we've seen interoperability issues with Aggregate servers when versions don't follow the 10 digit pattern. Briefcase doesn't parse version strings so far, so having alphanumeric versions shouldn't be an issue.

@DavisRayM DavisRayM mentioned this issue Nov 26, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavisRayM DavisRayM

Labels
Discussion
Projects
None yet
Milestone
Week39-40(2019)
Development

Successfully merging a pull request may close this issue.

Return XForm version even if the version is not a number onaio/onadata
3 participants
@ggalmazor @WinnyTroy @DavisRayM