Optional manifest url #1543
Merged
Optional manifest url #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukanga
reviewed
Jan 21, 2019
onadata/libs/renderers/renderers.py
Outdated
| self._to_xml(xml, value) | ||
| xml.endElement(key) | ||
| if key not in FORMLIST_MANDATORY_FIELDS and value is None: | ||
| pass |
There was a problem hiding this comment.
Could we use the continue keyword and avoid the else block? I think it seems cleaner that way.
ukanga
approved these changes
Jan 21, 2019
…e none exists. fixes #1519 Signed-off-by: Lincoln Simba <[email protected]>
Signed-off-by: Lincoln Simba <[email protected]>
Update tests Signed-off-by: Lincoln Simba <[email protected]>
Signed-off-by: Lincoln Simba <[email protected]>
lincmba
force-pushed
the
1519-optional-manifest-url
branch
from
b26c679
to
a016259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional fields in formList such as manifestUrl should not be included in formList incase none exists.
fixes #1519