Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional manifest url #1543

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Optional manifest url #1543

merged 4 commits into from
Jan 22, 2019

Commits on Jan 22, 2019

  1. Optional fields in formList such as manifestUrl should be empty incas… 

    …e none exists.

fixes #1519

Signed-off-by: Lincoln Simba <[email protected]>
    @lincmba
    lincmba committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    c744845 View commit details
    Browse the repository at this point in the history

  2. tests 

    Signed-off-by: Lincoln Simba <[email protected]>
    @lincmba
    lincmba committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    0405bc0 View commit details
    Browse the repository at this point in the history

  3. rid formList.xml of optional fields (manifestUrl) 

    Update tests

Signed-off-by: Lincoln Simba <[email protected]>
    @lincmba
    lincmba committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    eb9496d View commit details
    Browse the repository at this point in the history

  4. improve code 

    Signed-off-by: Lincoln Simba <[email protected]>
    @lincmba
    lincmba committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    a016259 View commit details
    Browse the repository at this point in the history