Make retrieving claims from decoded id_token configurable #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests
- Move EMAIL, FIRST_NAME, LAST_NAME to open_id_connect_tools
- ODK now supports string versions - Silence Codacy error
DavisRayM
force-pushed
the
open-id-claim-change
branch
from
c6eb1c9
to
a38b783
Compare
- Separate issue opened to deal with this change #1726 - Fix failing tests
DavisRayM
force-pushed
the
open-id-claim-change
branch
from
a38b783
to
2487998
Compare
ukanga
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to make the retrieval of claims from a decoded
id_tokenconfigurable by trying to retrieve claim_name values from the Open ID providers configuration.Changes implemented in this PR
get_claim_valuesfunction