Upgrade PyXForm to v0.15.1 #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
1720-pyxform-upgrade
branch
4 times, most recently
from
3127298
to
4f4c5f8
Compare
DavisRayM
force-pushed
the
1720-pyxform-upgrade
branch
3 times, most recently
from
76d191a
to
9ba9165
Compare
lincmba
previously approved these changes
Jan 29, 2020
DavisRayM
changed the title
WinnyTroy
previously approved these changes
Jan 29, 2020
DavisRayM
force-pushed
the
1720-pyxform-upgrade
branch
from
9ba9165
to
2614ee1
Compare
- Fix failing tests related to the change in /meta/instanceID binding More info: XLSForm/pyxform#94 - Fix failing test related to a change in the PyXform error raised when an invalid XML tag is found. More info: XLSForm/pyxform#22 - Fix failing tests related to the 'allow_duplicate_choice' setting not being present. More info: XLSForm/pyxform#23
- Duplicate choice values are no longer allowed in PyXForm. More info: XLSForm/pyxform#23 - Rename new_cascading_select.xls to duplicate_choice_form.xls - Replace choice_filter.xls file with choice_filter.xlsx; Duplicate of choice_filter.xls with allow_duplicate_choices setting
DavisRayM
force-pushed
the
1720-pyxform-upgrade
branch
from
2614ee1
to
707427f
Compare
DavisRayM
changed the title
ukanga
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
test_choice_duplicate_errornew_cascading_select.xlstoduplicate_choice_form.xlsnew_cascading_select.xlsx; Duplicate of thenew_cascading_select.xlsform with theallow_duplicate_choicessettingchoice_filter.xlswithchoice_filter.xlsx; Duplicate of thechoice_fields.xlsform with theallow_duplicate_choices` settingSteps taken to verify this change does what is intended
Pending steps
Side effects of implementing this change
duplicate_choice_valueerror may affect preexisting forms ?Closes #1720