Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XForm and Data ViewSet updates #1971

Merged
merged 7 commits into from
Dec 17, 2020
Merged

XForm and Data ViewSet updates #1971

merged 7 commits into from
Dec 17, 2020

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Dec 16, 2020

Changes / Features implemented

  • Utilize stored num_of_submissions value instead of recalculating the value when User requests XForm
  • Add ability to configure max_page_size
  • Retry pagination when an OperationalError is raised
  • Update documentation on the page and page_size query parameters
  • Modify how submission_count_for_today is tracked/calculated

Steps taken to verify this change does what is intended

  • Added Tests

Side effects of implementing this change

Closes #

ukanga
ukanga previously approved these changes Dec 16, 2020
@ukanga ukanga dismissed their stale review December 16, 2020 10:24

changes still expected on this branch.

@DavisRayM DavisRayM changed the title [WIP] XForm and Data ViewSet updates XForm and Data ViewSet updates Dec 16, 2020
Disable "form_versions" calculation for forms that have submissions that surpass
the "SUBMISSION_RETRIEVAL_THRESHOLD" setting
@DavisRayM DavisRayM merged commit 0517829 into master Dec 17, 2020
@DavisRayM DavisRayM deleted the data-endpoint-updates branch December 17, 2020 06:02
@DavisRayM DavisRayM mentioned this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants