Query optimization for the Briefcase viewset #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
briefcase-changes
branch
2 times, most recently
from
489a4a6
to
2b4efe0
Compare
DavisRayM
changed the title
Avoid multiple calls to `.count()` which case the application to re-query the database
Minor optimization for the `SELECT` query as we do not utilize any of the other columns within the instance table in the BriefcaseViewSet
…ueryset Not using the `num_of_submissions` attribute since it counts submissions which have not yet received all media files yet.
DavisRayM
force-pushed
the
briefcase-changes
branch
from
b4c3def
to
031fa06
Compare
DavisRayM
commented
Oct 5, 2021
DavisRayM
commented
Oct 5, 2021
DavisRayM
changed the title
DavisRayM
commented
Oct 5, 2021
ukanga
reviewed
Oct 6, 2021
| deleted_at__isnull=True) | ||
| instances = Instance.objects.filter( | ||
| xform=xform, deleted_at__isnull=True).values( | ||
| 'pk', 'uuid') |
There was a problem hiding this comment.
Are we using the uuid anywhere? We could just only return the pk.
There was a problem hiding this comment.
Yes, we're using it on the list endpoint https://github.com/onaio/onadata/blob/b406899b61/onadata/apps/logger/templates/submissionList.xml
ukanga
approved these changes
Oct 6, 2021
| deleted_at__isnull=True) | ||
| instances = Instance.objects.filter( | ||
| xform=xform, deleted_at__isnull=True).values( | ||
| 'pk', 'uuid') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
num_of_submissionsinstead of trying to count all the instances whennumEntriesis not specifiedinstancesusinglen()instead ofcount()to avoid an additional Database query & preload theinstancesbefore the renderpk&uuidcolumns from the database instead of all the instance table columns; The briefcase viewset does not utilize any of the other columnsSteps taken to verify this change does what is intended
Side effects of implementing this change
Improved performance on the briefcase viewset. Performance gain
Tests were done on a form with 4601 submissions
With changes & numEntries query param
Without changes & numEntries query param
With changes & No query param
Without changes & No query param
Before submitting this PR for review, please make sure you have:
Closes #