Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query optimization for the Briefcase viewset #2142

Merged
merged 6 commits into from
Oct 6, 2021
Merged

Query optimization for the Briefcase viewset #2142

merged 6 commits into from
Oct 6, 2021

Commits on Sep 29, 2021

  1. Calculate instance_count only when the instances queryset is a slice 

    Avoid multiple calls to `.count()` which case the application to
re-query the database
    @DavisRayM
    DavisRayM committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    81af06d View commit details
    Browse the repository at this point in the history

  2. Retrieve the pk & uuid fields only 

    Minor optimization for the `SELECT` query as we do not utilize any of
the other columns within the instance table in the BriefcaseViewSet
    @DavisRayM
    DavisRayM committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    2bbc025 View commit details
    Browse the repository at this point in the history

  3. Retrieve instance_count by retrieving the length of the instances q… 

    …ueryset

Not using the `num_of_submissions` attribute since it counts submissions
which have not yet received all media files yet.
    @DavisRayM
    DavisRayM committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    031fa06 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Update comment

    @DavisRayM
    DavisRayM authored Oct 5, 2021
    Configuration menu
    Copy the full SHA
    edc1def View commit details
    Browse the repository at this point in the history

  2. Remove trailing whitespace

    @DavisRayM
    DavisRayM authored Oct 5, 2021
    Configuration menu
    Copy the full SHA
    f63617b View commit details
    Browse the repository at this point in the history

  3. Check if instance_count is greater than 0

    @DavisRayM
    DavisRayM authored Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b406899 View commit details
    Browse the repository at this point in the history