Query data endpoint by submission review. Filter NULL review status
#2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinnyTroy
force-pushed
the
null_review_status
branch
2 times, most recently
from
7486de9
to
a55a701
Compare
WinnyTroy
changed the title
NULL review status
DavisRayM
reviewed
Sep 15, 2021
Comment on lines
124
to
127
| if '$or' not in list(query): | ||
| for k, v in query.items(): | ||
| if v is None: | ||
| or_where.extend([u"json->>'{}' IS NULL".format(k)]) |
There was a problem hiding this comment.
Seems like this functionality would not properly handle queries without the $or query in it; Just seems to check if the value is None and adds the query... should it handle querying the values passed in the query? or is that handled elsewhere
There was a problem hiding this comment.
Seems the query is handled in the _parse_where function could we extend that function to handle field_value when it's None instead of looping through the query here perhaps?
There was a problem hiding this comment.
Sounds good.
Made that change
WinnyTroy
force-pushed
the
null_review_status
branch
4 times, most recently
from
28e807c
to
bb3d52d
Compare
DavisRayM
previously approved these changes
Sep 16, 2021
denniswambua
previously approved these changes
Sep 17, 2021
WinnyTroy
dismissed stale reviews from denniswambua and DavisRayM
via
55e23d3
WinnyTroy
force-pushed
the
null_review_status
branch
from
bb3d52d
to
55e23d3
Compare
WinnyTroy
force-pushed
the
null_review_status
branch
from
55e23d3
to
0437f06
Compare
denniswambua
approved these changes
Sep 17, 2021
denniswambua
approved these changes
Sep 17, 2021
LeonRomo
pushed a commit
that referenced
this pull request
Nov 5, 2021
…#2144) * Add failing tests * Include ability to generate sql statement for NULL query strings. * Update data endpoint documentation
denniswambua
pushed a commit
that referenced
this pull request
Nov 11, 2021
* test on charts by grouping multiple fields * test on charts with content type * update the format to json when content type has been provided * styling fix * styling fix * Update onadata/apps/api/tests/viewsets/test_charts_viewset.py Co-authored-by: Davis Raymond <[email protected]> * Clean out Merged Datasets upon xform deletion. Clean out Form Media Files upon form deletion. Add documentation on clean up of filtered datasets (#2136) * Query data endpoint by submission review. Filter `NULL` review status (#2144) * Add failing tests * Include ability to generate sql statement for NULL query strings. * Update data endpoint documentation * Remove unnecessary test * test on charts by grouping multiple fields * test on charts with content type * update the format to json when content type has been provided * styling fix * styling fix * Update onadata/apps/api/tests/viewsets/test_charts_viewset.py Co-authored-by: Davis Raymond <[email protected]> * Remove unnecessary test Co-authored-by: Davis Raymond <[email protected]> Co-authored-by: Winnie Kiragu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
NULLSteps taken to verify this change does what is intended
Side effects of having these changes
PENDINGcan be thought of in 2 ways:3- For instances when the user had already provided a status, i.e approved/rejected and would like to return submission review status to pending.NULL- By default, if no review has been provided for the submission.Before submitting this PR for review, please make sure you have:
Closes #2112