Fix charts groupby multiple fields and check content type #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
reviewed
Sep 17, 2021
Co-authored-by: Davis Raymond <[email protected]>
DavisRayM
reviewed
Oct 22, 2021
Comment on lines
479
to
527
| def test_charts_groupby_two_fields(self): | ||
| data = { | ||
| 'field_name': 'age', | ||
| 'group_by': 'gender,pizza_fan' | ||
| } | ||
| request = self.factory.get('/charts', data) | ||
| force_authenticate(request, user=self.user) | ||
| response = self.view( | ||
| request, | ||
| pk=self.xform.id, | ||
| format='json') | ||
|
|
||
| expected = { | ||
| 'data': [ | ||
| { | ||
| 'gender': ['Female'], | ||
| 'pizza_fan': ['No'], | ||
| 'count': 1, | ||
| 'sum': 23.0, | ||
| 'mean': 23.0 | ||
| }, | ||
| { | ||
| 'gender': ['Female'], | ||
| 'pizza_fan': ['Yes'], | ||
| 'count': 1, | ||
| 'sum': 23.0, | ||
| 'mean': 23.0 | ||
| }, | ||
| { | ||
| 'gender': ['Male'], | ||
| 'pizza_fan': ['No'], | ||
| 'count': 1, | ||
| 'sum': 35.0, | ||
| 'mean': 35.0 | ||
| } | ||
| ], | ||
| 'data_type': 'numeric', | ||
| 'field_label': 'How old are you?', | ||
| 'field_xpath': 'age', | ||
| 'field_name': 'age', | ||
| 'field_type': 'integer', | ||
| 'grouped_by': ['gender', 'pizza_fan'], | ||
| 'xform': self.xform.pk | ||
| } | ||
|
|
||
| response.render() | ||
| res = json.loads(response.content.decode('utf-8')) | ||
| self.assertEqual(200, response.status_code) | ||
| self.assertEqual(expected, res) |
There was a problem hiding this comment.
@LeonRomo In what scenario would this test fail? Doesn't seem to fail on the current master branch
There was a problem hiding this comment.
@DavisRayM I don't think that funtionality has been tested and this is good to test it and increase our test coverage.
There was a problem hiding this comment.
@denniswambua Thought it was related to one of the issues this closes #2090. If it's not then we may need to add a test for it since I don't see a test for it in this PR
There was a problem hiding this comment.
@DavisRayM it is testing #2090
There was a problem hiding this comment.
@denniswambua I would then expect the test to fail on master.... unless the issue is no longer occurring in the latest release.
LeonRomo
force-pushed
the
fix-charts-groupby-multiple-fields
branch
from
a94612f
to
9ef62f7
Compare
Co-authored-by: Davis Raymond <[email protected]>
denniswambua
approved these changes
Nov 11, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
test on charts by grouping multiple fields.
test on charts with content-type as application/JSON
update the format to JSON in the even content type has been provided
Steps taken to verify this change does what is intended
tested locally and used the unit test
Side effects of implementing this change
N/A
Before submitting this PR for review, please make sure you have:
Closes #
#2089