Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check attempts is truthy before int comparison #2618

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

ukanga
Copy link
Member

@ukanga ukanga commented Jun 24, 2024

Closes #2617

Changes / Features implemented

Steps taken to verify this change does what is intended

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

@ukanga ukanga force-pushed the check-attempts-is-not-none branch from 01b0d56 to 7c821df Compare June 24, 2024 12:36
FrankApiyo
FrankApiyo previously approved these changes Jun 24, 2024
kelvin-muchiri
kelvin-muchiri previously approved these changes Jun 24, 2024
KipSigei
KipSigei previously approved these changes Jun 24, 2024
@ukanga ukanga dismissed stale reviews from KipSigei and kelvin-muchiri via a5e5bb8 June 24, 2024 13:40
@ukanga ukanga force-pushed the check-attempts-is-not-none branch 2 times, most recently from ea1da26 to 037bfc0 Compare June 24, 2024 16:23
KipSigei
KipSigei previously approved these changes Jun 27, 2024
@ukanga ukanga force-pushed the check-attempts-is-not-none branch from 3abb917 to 98ca445 Compare July 3, 2024 16:08
@ukanga ukanga merged commit f4e8adb into main Jul 3, 2024
10 checks passed
@ukanga ukanga deleted the check-attempts-is-not-none branch July 3, 2024 16:44
@KipSigei KipSigei mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: '>=' not supported between instances of 'NoneType' and 'int'
4 participants