-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect certain kinds of invalid polygons when slicing into tiles #499
Conversation
https://github.com/onthegomap/planetiler/actions/runs/4265008119 ℹ️ Base Logs afc2470
ℹ️ This Branch Logs 71bffa0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach makes sense to me, seems like the fix should prevent this kind of issue. I can't immediately think of another way the inner ring could break that wouldn't be handled here
planetiler-core/src/test/java/com/onthegomap/planetiler/PlanetilerTests.java
Outdated
Show resolved
Hide resolved
…ilerTests.java Co-authored-by: Erik Price <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Fix #496 by detecting the case where a inner polygon ring (hole) intersects a tile not contained by or touching an outer ring. Without this check, feature renderer assumes the hole is taking a chunk out of a larger filled area so fills the entire tile first.
FeatureRenderer
detects this case, fixes the polygon, and tries again.