-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix geometry errors #526
Merged
Fix geometry errors #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/4472591340 ℹ️ Base Logs 65f620d
ℹ️ This Branch Logs bcbcd4b
|
Kudos, SonarCloud Quality Gate passed! |
Tested on planet, no errors: https://gist.github.com/msbarry/945b6aea4d52717a9c98461bd8fb7919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #509 which ended up being caused by this shape (green is outer shell, red and blue are inner) when the red hole was processed before blue:
The issue was that when the blue shape skips over tiles in a column that are outside the shape, it was treating them like skipping over holes that were inside the shape, which failed with the new check added in #499 because the tile was not already filled.
It shows up for several multipolygons in the Lena Delta region: https://www.openstreetmap.org/#map=7/72.850/125.969 so I exported one as xml and included in unit tests.
Also fix #511 by fixing invalid polygons more aggressively if reducing the precision still fails after fixing once with a
.buffer(0)