fix(cli/rm/rm.go): using panic is not user friendly #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I manually tested the cli and concluded that it's too easy to reach the panic caused by runtimex.Try0 over there and it would expose panics to users too frequently. Let's just convert those into normal error checks. Here is what we would previously get: ``` % ./ooniprobe rm ? Are you sure you wish to delete the result #0 [Use arrows to move, type to filter] true > false panic: Try0: interrupt [...] ``` So, here I just pressed ^D and got a panic. Ouch! After the diff, we have this: ``` % ./ooniprobe rm ? Are you sure you wish to delete the result #0 false ⨯ failure in main command error=canceled by user ``` and: ``` % ./ooniprobe rm --all ? Are you sure you wish to delete ALL results false ⨯ failure in main command error=canceled by user ``` It seems much better, isn't it? Part of the QA for ooni/probe#2722
bassosimone
commented
May 17, 2024
bassosimone
commented
May 17, 2024
bassosimone
added a commit
that referenced
this pull request
May 17, 2024
I manually tested the cli and concluded that it's too easy to reach the panic caused by runtimex.Try0 over there and it would expose panics to users too frequently. Let's just convert those into normal error checks. Here is what we would previously get: ``` % ./ooniprobe rm ? Are you sure you wish to delete the result #0 [Use arrows to move, type to filter] true > false panic: Try0: interrupt [...] ``` So, here I just pressed ^D and got a panic. Ouch! After the diff, we have this: ``` % ./ooniprobe rm ? Are you sure you wish to delete the result #0 false ⨯ failure in main command error=canceled by user ``` and: ``` % ./ooniprobe rm --all ? Are you sure you wish to delete ALL results false ⨯ failure in main command error=canceled by user ``` It seems much better, isn't it? Part of the QA for ooni/probe#2722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually tested the cli and concluded that it's too easy to reach the panic caused by runtimex.Try0 over there and it would expose panics to users too frequently.
Let's just convert those into normal error checks. Here is what we would previously get:
So, here I just pressed ^D and got a panic. Ouch!
After the diff, we have this:
and:
It seems much better, isn't it?
Part of the QA for ooni/probe#2722