ooniprobe 3.22.0 #172462
Merged
ooniprobe 3.22.0 #172462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
ZhongRuoyu
approved these changes
May 22, 2024
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
More in detail, here's what has changed:
✨ Preparing Web Connectivity LTE for use in production
We worked towards closing all the open Web Connectivity LTE issues, such that we can finally be well placed to run an A/B testing between the v0.4 and LTE using this version of the OONI Probe Engine.
🐛 Prioritize DNS results when communicating with backends
We documented the strategy to communicate with backends, including the OONI backend, and we discussed the design as part of the ooni/probe-cli#1552. During such a review, it was requested to modify the policy with which we communicate with the backends, so that the DNS results have higher priority. The main concern of this change request was to avoid long recovery periods if the currently deployed bridge becomes unavailable as well as to tilt the overall design such that uncensored OONI Probe users communicate with the backends in the simplest possible way.
bridgesPolicywith DNS success by @bassosimone in feat(enginenetx): testbridgesPolicywith DNS success ooni/probe-cli#1554🚧 Refactor and document communication with the OONI backend
We wanted to document the interaction with the OONI backend and specifically with the "probe services" (i.e., the collection of APIs used by OONI Probe), per ooni/probe#2700. To this end, we seized the opportunity to simplify the code interactions, reduce the number of used packages, and refactor the code to improve its reliability and future usability.
📖 Documenting the release process
We were asked to document the release process in ooni/probe#2698, and the resulting work is this:
🚧 Releasing & maintenance
This set of changes deal with preparing a release. In particular, in this case, we took on the chore of reducing the number of warnings emitted by
gosec, such that its output can actually be informative and actionable (there was lots of noise). In terms of behavioral changes in theooniprobebinary, these are the two most "impactful" changes:I explicitly ignore errors when resetting with
-ftheOONI_HOMEdirectory, to keep the previous idempotent behavior, because I think that otherwise the desktop app may emit errors if asked to delete theOONI_HOMEmultiple times: https://github.com/ooni/probe-cli/pull/1603/files#diff-2e841e5388e3f75b0ab808e74d5b34a9ebb72466a508daecda35625a7eab5c7fR29I have improved how we manage
surveyerrors: https://github.com/ooni/probe-cli/pull/1603/files#diff-3e09d6a095d686f531f06efe21b6e430b311340af5ce74989f110dc05424cbcdR24 and fix(cli/rm/rm.go): using panic is not user friendly ooni/probe-cli#1608I am now reporting an error if we fail to update the database to set the upload status: https://github.com/ooni/probe-cli/pull/1603/files#diff-2a4cd822f78eb174dc7c6b88e3ab71be4810624b358b98109c10bcb5371e4844R249
I have now configured timeouts for receiving headers in
oohelperd: https://github.com/ooni/probe-cli/pull/1603/files#diff-663f720a0015bc642e1957e965f9bc9115cea500fc0268bf5a6e22b5ad7cb44dR111Here's the full list of pull requests:
🚧 Minor changes & bug fixes
URL=>Urlto fix iOS by @aanorbel in fix(oonimkall.HTTPRequest):URL=>Urlto fix iOS ooni/probe-cli#1545Full Changelog: ooni/probe-cli@v3.21.0...v3.22.0