Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the number of comments next to a commit in the saved search view #44

Closed
philc opened this issue Sep 13, 2011 · 1 comment
Closed

Comments

@philc
Copy link
Contributor

philc commented Sep 13, 2011

This will help you spot commits under discussion. In the case where you're trying to get your list down to zero because you're filtering by unapproved commtis only, if there's a commit that's sitting there unapproved and has a bunch of comments next to it, this will help you remember that it is a work in progress.

We should not show the comment indicator next to the commit if there are no comments, and we should make the indicator really low profile, e.g. [num][32px comment icon]

@cespare
Copy link
Contributor

cespare commented Sep 24, 2011

From #67: Mike suggests showing approved status as well. We could probably do this in a minimal way, such as showing a "+1" by approved commits or giving them a different bg color.

cespare added a commit that referenced this issue Sep 27, 2011
@cespare cespare closed this as completed Sep 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants