Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of comments and approval status in commit list #67

Closed
mstyer opened this issue Sep 24, 2011 · 2 comments
Closed

Show number of comments and approval status in commit list #67

mstyer opened this issue Sep 24, 2011 · 2 comments

Comments

@mstyer
Copy link

mstyer commented Sep 24, 2011

It would be helpful to know by looking at the commit list which commits have been commented on and/or approved. I know you can click the "Show only approved" box, but being able to see the full list while also seeing which commits have been approved would be helpful too.

Adding how many files were edited and/or number of changed lines might also be useful.

@cespare
Copy link
Contributor

cespare commented Sep 24, 2011

We're already planning on showing number of comments, see issue #44. I'll add the idea to that issue about showing approval status -- we should consider showing that as well.

The other metadata seems a bit much for that view. We want to keep the commit list concise.

@philc
Copy link
Contributor

philc commented Sep 24, 2011

Yep, I like the idea of marking the commits which are approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants