Handle policy dependencies of Gatekeeper types #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, policy dependencies could only handle objects that had a `status.complianceState` field. Gatekeeper ConstraintTemplates and Constraints do not have this field, but we assign them a compliance in a similar way elsewhere. This commit allows these Gatekeeper types to be used for policy dependencies like a user might expect. Refs: - https://issues.redhat.com/browse/ACM-8998 Signed-off-by: Justin Kulikauskas <[email protected]>
mprahl
reviewed
Jan 5, 2024
mprahl
reviewed
Jan 5, 2024
mprahl
reviewed
Jan 9, 2024
mprahl
reviewed
Jan 9, 2024
mprahl
reviewed
Jan 9, 2024
mprahl
reviewed
Jan 9, 2024
mprahl
reviewed
Jan 9, 2024
Since there are more cases now(for the Gatekeeper types) it became clear that diagnosing why a policy dependency was not met might be difficult. This adds reasons to the unmet dependencies which will be logged, and which might in the future be used in status messages. Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
8998-pending-on-gk-objs
branch
from
d6065be
to
af53fe5
Compare
mprahl
approved these changes
Jan 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit efe129c
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, policy dependencies could only handle objects that had a
status.complianceStatefield. Gatekeeper ConstraintTemplates and Constraints do not have this field, but we assign them a compliance in a similar way elsewhere. This commit allows these Gatekeeper types to be used for policy dependencies like a user might expect.Refs: