Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/governance-policy-framework-addon: #105 #240

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

magic-mirror-bot[bot]
Copy link

Originally, policy dependencies could only handle objects that had a
`status.complianceState` field. Gatekeeper ConstraintTemplates and
Constraints do not have this field, but we assign them a compliance in
a similar way elsewhere. This commit allows these Gatekeeper types to
be used for policy dependencies like a user might expect.

Refs:
 - https://issues.redhat.com/browse/ACM-8998

Signed-off-by: Justin Kulikauskas <[email protected]>
(cherry picked from commit b681524)
Since there are more cases now(for the Gatekeeper types) it became clear
that diagnosing why a policy dependency was not met might be difficult.
This adds reasons to the unmet dependencies which will be logged, and
which might in the future be used in status messages.

Signed-off-by: Justin Kulikauskas <[email protected]>
(cherry picked from commit efe129c)
Copy link

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Jan 10, 2024

@magic-mirror-bot magic-mirror-bot bot merged commit f96d024 into main Jan 10, 2024
13 of 14 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1704905510302 branch January 10, 2024 17:20
@JustinKuli
Copy link

/cherry-pick release-2.9

@openshift-cherrypick-robot

@JustinKuli: new pull request created: #242

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants