Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark scheme of the portal is unworkable #1924

Closed
hlmr-dave opened this issue Aug 25, 2022 · 5 comments · Fixed by #2201
Closed

Dark scheme of the portal is unworkable #1924

hlmr-dave opened this issue Aug 25, 2022 · 5 comments · Fixed by #2201
Assignees
Labels
bug Something isn't working formio Limitation in Formio.js
Milestone

Comments

@hlmr-dave
Copy link

Product versie / Product version

latest

Omschrijf het probleem / Describe the bug

The "dark scheme" of the Form designer is unworkable. Most of the text is unreadable and in some cases the action buttons as well.

Stappen om te reproduceren / Steps to reproduce

Screenshot 2022-08-25 at 16 33 07
Screenshot 2022-08-25 at 16 33 31

Verwacht gedrag / Expected behavior

Please disable it and make it so that the default is always applied. Now I am blocked because of this unfinished functionality.

Screen resolution

No response

Device

Desktop

OS

iOS

Browser

Chrome

@hlmr-dave hlmr-dave added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Aug 25, 2022
@sergei-maertens sergei-maertens added formio Limitation in Formio.js and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Aug 29, 2022
@sergei-maertens sergei-maertens added this to the Release 2.0.1 milestone Oct 7, 2022
@SilviaAmAm SilviaAmAm self-assigned this Oct 17, 2022
@SilviaAmAm
Copy link
Contributor

SilviaAmAm commented Oct 17, 2022

Things to fix:

  • Hidden fields
  • Checkboxes
  • Warning session is expiring
  • Content component (the widget is still light coloured, but the text is now also light coloured) => Bandaid
  • Email registration (some fields are white and some are dark)
  • File upload component
  • Component with multiple values (the "add value" button is too dark in the editor)
  • SDK Snippet
  • Select component (the dropdown part is white with light text)

(Advanced logic was removed from the fieldset)

SilviaAmAm added a commit that referenced this issue Oct 18, 2022
SilviaAmAm added a commit that referenced this issue Oct 19, 2022
SilviaAmAm added a commit that referenced this issue Oct 19, 2022
SilviaAmAm added a commit that referenced this issue Oct 19, 2022
@hlmr-erik
Copy link

Don't know if these were already part of the re-opened story, but:
The MFA-QR code is unreadable in Dark mode:
image
(I obviously blurred out the QR code)

Same with the type of buttons like the 'Add form' button:
image

@sergei-maertens
Copy link
Member

Can you please open a new issue for these findings?

@hlmr-erik
Copy link

Done: #2671 As it turned out, part of my initial finding was because of the 'Dark Reader' extension I used to try to reproduce the problem. However, part of it persists in Windows' native dark mode.

@sergei-maertens
Copy link
Member

Thanks :)

The framework support (in this version of the framework) is limited to the media queries for dark/light scheme preferences. I think I saw that the next LTS release relaxes that a bit by using themes/theme names to target, so I'm not entirely sure how things behave with OS-mandated dark-mode etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working formio Limitation in Formio.js
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants