-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1924] Dark theme fixes #2201
[#1924] Dark theme fixes #2201
Conversation
cf5080b
to
eecc207
Compare
eecc207
to
8eb8783
Compare
Codecov ReportBase: 93.36% // Head: 93.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2201 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 636 636
Lines 20390 20390
Branches 1898 1898
=======================================
Hits 19038 19038
Misses 1051 1051
Partials 301 301 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
To style the checkboxes as well, you can use
color-scheme: dark
in CSS (https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme), that's how github does it. You can also apply that todate
inputs, those are currently still "light" scheme. -
The product edit form still has light-theme WYSIWYG fields, those are rendered via the django package afaik. These should also be adapted to use the correct theme (and preferably in a generic way)
I hope one day we can also hook these things up in storybook and have automated UI regression testing 😬
I see there is this issue for it: jazzband/django-tinymce#375. I'll look into it and see if I can figure out how to make it detect the dark theme! |
3243bb1
to
e34dc56
Compare
edd7a9d
to
0143820
Compare
Fixes #1924