Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1924] Dark theme fixes #2201

Merged
merged 13 commits into from
Oct 21, 2022
Merged

[#1924] Dark theme fixes #2201

merged 13 commits into from
Oct 21, 2022

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Oct 17, 2022

Fixes #1924

@SilviaAmAm SilviaAmAm marked this pull request as draft October 17, 2022 14:02
@SilviaAmAm SilviaAmAm marked this pull request as ready for review October 19, 2022 08:21
@codecov-commenter
Copy link

Codecov Report

Base: 93.36% // Head: 93.36% // No change to project coverage 👍

Coverage data is based on head (8eb8783) compared to base (c1a4742).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2201   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files         636      636           
  Lines       20390    20390           
  Branches     1898     1898           
=======================================
  Hits        19038    19038           
  Misses       1051     1051           
  Partials      301      301           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • To style the checkboxes as well, you can use color-scheme: dark in CSS (https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme), that's how github does it. You can also apply that to date inputs, those are currently still "light" scheme.

  • The product edit form still has light-theme WYSIWYG fields, those are rendered via the django package afaik. These should also be adapted to use the correct theme (and preferably in a generic way)

I hope one day we can also hook these things up in storybook and have automated UI regression testing 😬

src/openforms/scss/components/builder/_admin-fixes.scss Outdated Show resolved Hide resolved
src/openforms/scss/components/builder/_admin-fixes.scss Outdated Show resolved Hide resolved
src/openforms/scss/components/builder/_builder.scss Outdated Show resolved Hide resolved
src/openforms/scss/vendor/_rjsf-field.scss Outdated Show resolved Hide resolved
@SilviaAmAm
Copy link
Contributor Author

* The product edit form still has light-theme WYSIWYG fields, those are rendered via the django package afaik. These should also be adapted to use the correct theme (and preferably in a generic way)

I see there is this issue for it: jazzband/django-tinymce#375. I'll look into it and see if I can figure out how to make it detect the dark theme!

@sergei-maertens sergei-maertens merged commit 527150d into master Oct 21, 2022
@sergei-maertens sergei-maertens deleted the fix/1924-dark-theme branch October 21, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark scheme of the portal is unworkable
3 participants