Jak 2: Finnish translations #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
xTVaser
reviewed
May 25, 2024
decompiler/config/jak2/all-types.gc
Outdated
| @@ -8774,6 +8774,7 @@ Unlike [[engine]], users can use [[engine-pers]] as a parent class." | |||
| (progress-graphics-ps2-lod-dist #x1337) | |||
| (progress-graphics-msaa-off #x1338) | |||
| (progress-graphics-display #x1339) | |||
| (language-name-finnish #x133a) | |||
There was a problem hiding this comment.
you need to also add this to decompiler/config/jak2/all-types.gc and the failing builds will pass.
LGTM! |
|
Conflicts need to be resolved before this can be merged |
|
Added to menus and tested, id encourage double checking my work though: |
|
Added the country flag |
|
I think you can ignore the failing build, there's a mistake in it that I need to fix. Is this ready for review now or are you still working on it? |
|
I think it's ready now |
|
ok to test |
xTVaser
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finnish translations for Jak 2. These include cutscenes and all game text.
All subtitle timings for cutscenes as well as non-cutscenes have been edited for a better flow and to fit the 4x3 ratio.
I've been working on these solo for the most part so any input from other finns would be appreciated.
A few issues in the progress menu I mentioned in #3504 still persist
I couldn't figure out how to add Finnish to the options menu, so I'm gonna need someone else to do that part. 💀
But I was able to add them to the debug menu.
I also increased subtitle heap so hopefully that doesn't break anything.
Fixes #3620