Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in cycle_load()? #16

Closed
ulrichfilippi opened this issue Nov 19, 2018 · 2 comments
Closed

Bug in cycle_load()? #16

ulrichfilippi opened this issue Nov 19, 2018 · 2 comments

Comments

@ulrichfilippi
Copy link

In cycle_load(), for a FridgeFreezer, calculated power is currently standby (zero for FridgeFreezer) except for single minutes where it is cycle_power (190 for FridgeFreezer). In other words, P is [0, ..., 0, 190, 0, ..., 0, 190, 0, ...]. Therefore, cycle_power is kept only for one minute, independent of cycle_length. Is this a bug or did I misinterpret?

@Mathadon
Copy link
Member

@rubenbaetens @cprotopa do you have some wisdom to share about this?

@cprotopa
Copy link
Contributor

Indeed, there is a problem with the implementation, the power is only kept for the 1st minute of the cycle. I'll need to take a closer look to propose a fix to this model. Thanks for pointing it out!

cprotopa added a commit that referenced this issue Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants