Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit should fix the
cycle_load
model inresidential.py
, reported in #16 . However, calibration for these types of loads should still be done with the new model (updating thecal
value inAppliances.py
).Also note the model has some assumptions that could be changed, e.g. that the cycle length and delay are constant throughout the year, and that the power is the mean power assigned for that appliance (this could be sampled instead).