Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown version #414

Merged

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Jul 22, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

[Please describe the motivation of this PR and the goal you want to achieve through this PR.](https://readthedocs.org/projects/mmcv/builds/17455215/

Failed to build docs due to breaking changes of markdown3.4. More details at ryanfox/sphinx-markdown-tables#36.)https://readthedocs.org/projects/mmcv/builds/17455215/

Failed to build docs due to breaking changes of markdown3.4. More details at ryanfox/sphinx-markdown-tables#36.

Modification

Fix the markdown version.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 changed the base branch from main to dev July 22, 2022 07:19
@zytx121 zytx121 requested a review from ZwwWayne July 22, 2022 07:20
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #414 (e845ff2) into dev (36de5f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #414   +/-   ##
=======================================
  Coverage   29.46%   29.46%           
=======================================
  Files         121      121           
  Lines        8495     8495           
  Branches     1289     1289           
=======================================
  Hits         2503     2503           
  Misses       5891     5891           
  Partials      101      101           
Flag Coverage Δ
unittests 29.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36de5f6...e845ff2. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 575a757 into open-mmlab:dev Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants