Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown 3.4 causes TypeError due to breaking changes #36

Closed
catch-21 opened this issue Jul 15, 2022 · 5 comments
Closed

Markdown 3.4 causes TypeError due to breaking changes #36

catch-21 opened this issue Jul 15, 2022 · 5 comments

Comments

@catch-21
Copy link

Markdown 3.4 has just been released and it brings breaking changes to v0.0.15

...lib/python3.7/site-packages/sphinx_markdown_tables/__init__.py", line 24, in process_tables
    table_processor = markdown.extensions.tables.TableProcessor(md.parser)
TypeError: __init__() missing 1 required positional argument: 'config'

See Python-Markdown 3.4 Release Notes

Fix required here: https://github.com/ryanfox/sphinx-markdown-tables/blob/master/sphinx_markdown_tables/__init__.py#L24
@Dzordzu
Copy link
Contributor

Dzordzu commented Jul 15, 2022

#37

@Dzordzu
Copy link
Contributor

Dzordzu commented Jul 15, 2022

For now I suggest pip install git+https://github.com/Dzordzu/sphinx-markdown-tables.git@markdown-patch

@victorlin victorlin mentioned this issue Jul 15, 2022
Closed
@zhouzaida zhouzaida mentioned this issue Jul 16, 2022
Merged
7 tasks
@frgfm
Copy link

frgfm commented Jul 16, 2022

I can confirm, I experienced the same problem today. Adding markdown<3.4.0 to the version specifiers for now!

This was referenced Jul 16, 2022
Merged
Merged
@tdene
Copy link

tdene commented Jul 16, 2022

Also experiencing the same issue, as is elyra-ai/elyra#2837

@ZiniuYu ZiniuYu mentioned this issue Jul 18, 2022
Merged
@b31ngd3v b31ngd3v mentioned this issue Jul 18, 2022
Merged
tsibley added a commit to nextstrain/sphinx-theme that referenced this issue Jul 18, 2022
@tsibley
Workaround compatibility issue with sphinx-markdown-tables and markdo…
88db52c 
…wn packages

See commentary in this commit, the upstream issue¹, our initial tracking
issue² (in another repo), and our Slack thread.³

¹ ryanfox/sphinx-markdown-tables#36
² nextstrain/ncov#982
³ https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1658148441308079
This was referenced Jul 18, 2022
Merged
Closed
@numb3r3 numb3r3 mentioned this issue Jul 19, 2022
Merged
@ipdemes ipdemes mentioned this issue Jul 19, 2022
Merged
@tsibley tsibley mentioned this issue Jul 19, 2022
Closed
@lvhan028 lvhan028 mentioned this issue Jul 20, 2022
Merged
This was referenced Jul 20, 2022
Closed
Merged
@pengzhendong pengzhendong mentioned this issue Jul 21, 2022
Merged
@jcfr jcfr mentioned this issue Jul 21, 2022
Closed
jcfr added a commit to jcfr/Slicer that referenced this issue Jul 21, 2022
@jcfr
COMP: Fix sphinx documentation build due to breaking change in markdown
beef05e 
This commit workarounds backward incompatible change introduced in
Markdown 3.4 through Python-Markdown/markdown@659a43659 (Update th/td
to use style attribute)

It addresses error like the following:

  Extension error (sphinx_markdown_tables):
  Handler <function process_tables at 0x7f12fd69dc20> for event 'source-read' threw an exception (exception: __init__() missing 1 required positional argument: 'config')

See ryanfox/sphinx-markdown-tables#36
and https://python-markdown.github.io/change_log/release-3.4/
@jcfr jcfr mentioned this issue Jul 21, 2022
Merged
@yaooqinn yaooqinn mentioned this issue Jul 21, 2022
Open
3 tasks
@sevagh sevagh mentioned this issue Jul 21, 2022
Merged
jcfr added a commit to Slicer/Slicer that referenced this issue Jul 21, 2022
@jcfr
COMP: Fix sphinx documentation build due to breaking change in markdown
19377bc 
This commit workarounds backward incompatible change introduced in
Markdown 3.4 through Python-Markdown/markdown@659a43659 (Update th/td
to use style attribute)

It addresses error like the following:

  Extension error (sphinx_markdown_tables):
  Handler <function process_tables at 0x7f12fd69dc20> for event 'source-read' threw an exception (exception: __init__() missing 1 required positional argument: 'config')

See ryanfox/sphinx-markdown-tables#36
and https://python-markdown.github.io/change_log/release-3.4/
@TheaperDeng TheaperDeng mentioned this issue Jul 22, 2022
Closed
@zytx121 zytx121 mentioned this issue Jul 22, 2022
Merged
@ns-rse ns-rse mentioned this issue Jul 22, 2022
Closed
@alex3236 alex3236 mentioned this issue Jul 22, 2022
Merged
@ryanfox ryanfox closed this as completed Jul 24, 2022
ogoffart added a commit to slint-ui/slint that referenced this issue Jul 25, 2022
@ogoffart
Unpin the markdown dep
e98a8d3 
Because ryanfox/sphinx-markdown-tables#36 was
fixed, and now the workaround is actually causing an error
@ns-rse ns-rse mentioned this issue Jul 25, 2022
Merged
ogoffart added a commit to slint-ui/slint that referenced this issue Jul 25, 2022
@ogoffart
Unpin the markdown dep
0c7ad1a 
Because ryanfox/sphinx-markdown-tables#36 was
fixed, and now the workaround is actually causing an error
@tsibley tsibley mentioned this issue Jul 25, 2022
Closed
@tsibley
Copy link

tsibley commented Jul 25, 2022

If you're now experiencing similar TypeErrors because you worked around this issue by pinning markdown<3.4 (or equivalent), see #38.

@ns-rse ns-rse mentioned this issue Jul 28, 2022
Closed
theodrim added a commit to 90poe/vault-secrets-operator that referenced this issue Aug 4, 2022
@theodrim
Use fixed version of sphinx_markdown_tables
0cbb178 
More info ryanfox/sphinx-markdown-tables#36
@theodrim theodrim mentioned this issue Aug 4, 2022
Merged
theodrim added a commit to 90poe/vault-secrets-operator that referenced this issue Aug 4, 2022
@theodrim
Use fixed version of sphinx_markdown_tables (#15)
949e813 
More info ryanfox/sphinx-markdown-tables#36
vvolkl added a commit to vvolkl/key4hep-doc that referenced this issue Sep 22, 2022
@vvolkl
[ci] bump sphinx-markdown-tables to fix incompatibility with py-markdown
21ddbca 
See ryanfox/sphinx-markdown-tables#36
vvolkl added a commit to key4hep/key4hep-doc that referenced this issue Sep 22, 2022
@vvolkl
[ci] bump sphinx-markdown-tables to fix incompatibility with py-markdown
27952aa 
See ryanfox/sphinx-markdown-tables#36
lassoan added a commit to Slicer/Slicer that referenced this issue Sep 25, 2022
@lassoan
DOC: Remove sphinx-markdown-tables workaround
d51d466 
Fix was integrated into the official release (ryanfox/sphinx-markdown-tables#36), use that instead of a private patch version (which is no longer available).
@lassoan lassoan mentioned this issue Sep 25, 2022
Merged
lassoan added a commit to Slicer/Slicer that referenced this issue Sep 25, 2022
@lassoan
DOC: Remove sphinx-markdown-tables workaround
50f807c 
Fix was integrated into the official release (ryanfox/sphinx-markdown-tables#36), use that instead of a private patch version (which is no longer available).
jcfr added a commit to jcfr/ci-sandbox that referenced this issue Dec 1, 2022
@jcfr
DOC: Remove sphinx-markdown-tables workaround
980df8d 
Fix was integrated into the official release (ryanfox/sphinx-markdown-tables#36), use that instead of a private patch version (which is no longer available).

See Slicer/Slicer@50f807cc1
@frgfm frgfm mentioned this issue Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tsibley @ryanfox @Dzordzu @frgfm @tdene @catch-21