-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic lift floor hole generation #196
Conversation
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically cutting the lift holes is an excellent capability. I've left some in-line comments about spots where the implementation can be improved, but there's one thing I noticed in particular that I'm not sure where in the code it would be happening:
When a floor is completely divided on two sides by a lift, one entire half of the floor will end up being deleted. To illustrate this, here are some before and after screenshots of the hotel. In the "after" picture, I've moved the lift into the hallway in such a way that the hallway should be fully split in two. Instead, only half of the hallway remains at all:
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Yea I noticed this as well and I think it's just a consequence of the triangulation algorithm. |
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New feature implementation
Implemented feature
This PR adds automatic lift floor hole generation for lift shafts. It switches our path library from
lyon
togeo
since the latter supports boolean operations between polygons, otherwise we would have to write our own.Example below:
Screencast.from.2024-01-12.11-02-03.webm