Introducing model descriptions and instances #230
Draft
+3,544
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
mxgrey
reviewed
Jul 25, 2024
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
Signed-off-by: Reuben Thomas <[email protected]>
|
Hello! This PR looks really good so far, tested out on my machine and things are working well. To help with further review, could you update the merge conflicts from the recent changes on |
|
@xiyuoh Reuben is back to school full time, so it will be on us to make any changes needed to bring this PR to completion, including fixing merge conflicts. |
|
@mxgrey Gotcha, thanks for letting me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to separate model descriptions from instances. When a model description is changed, for instance its mesh or kinematic properties, all of its instances should also be changed. The user should also be able to change the description of an instance.