Add rmf_task_sequence to workflows, lint #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <[email protected]>
Yadunund
approved these changes
Jun 19, 2023
aaronchongth
added a commit
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 40f3e92) Signed-off-by: Aaron Chong <[email protected]>
aaronchongth
added a commit
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 40f3e92) Signed-off-by: Aaron Chong <[email protected]>
Yadunund
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Task request time and initiator in Booking (#81) * Fixed missing constructor implementation, commented to deprecate next time, new booking constructor Signed-off-by: Aaron Chong <[email protected]> * Add requester to factories, add request time and initiator to ChargeBattery and Loop Signed-off-by: Aaron Chong <[email protected]> * Using requester instead of initiator, added new make API to legacy Clean and Deliver Signed-off-by: Aaron Chong <[email protected]> * lint Signed-off-by: Aaron Chong <[email protected]> * Revert to original constructor with optional arguments appended, propagated changes to all constructors and make functions Signed-off-by: Aaron Chong <[email protected]> * Move description into booking, lint Signed-off-by: Aaron Chong <[email protected]> * Pass a clock functor to ParkRobotFactory Signed-off-by: Aaron Chong <[email protected]> * Using non-deprecated Request constructor Signed-off-by: Aaron Chong <[email protected]> * new make_request API to include requester and request time Signed-off-by: Aaron Chong <[email protected]> * Overload TaskPlanner constructor with a name argument Signed-off-by: Aaron Chong <[email protected]> * Retained old API and marked as deprecated Signed-off-by: Aaron Chong <[email protected]> * Overloading booking instead of adding default arguments Signed-off-by: Aaron Chong <[email protected]> * Overloading all affected functions with non optional arguments Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Revert deprecation tag on Request, to be done in a separate PR Signed-off-by: Aaron Chong <[email protected]> * Argument name changes, linting, documentation Signed-off-by: Aaron Chong <[email protected]> * TaskPlanner constructor to have planner id as first argument Signed-off-by: Aaron Chong <[email protected]> * request factories to accept a callback that returns the current time Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit a7875a9) Signed-off-by: Aaron Chong <[email protected]> * Add rmf_task_sequence to workflows, lint (#91) Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 40f3e92) Signed-off-by: Aaron Chong <[email protected]> * Only running iron jammy workflows Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>
Yadunund
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Task request time and initiator in Booking (#81) * Fixed missing constructor implementation, commented to deprecate next time, new booking constructor Signed-off-by: Aaron Chong <[email protected]> * Add requester to factories, add request time and initiator to ChargeBattery and Loop Signed-off-by: Aaron Chong <[email protected]> * Using requester instead of initiator, added new make API to legacy Clean and Deliver Signed-off-by: Aaron Chong <[email protected]> * lint Signed-off-by: Aaron Chong <[email protected]> * Revert to original constructor with optional arguments appended, propagated changes to all constructors and make functions Signed-off-by: Aaron Chong <[email protected]> * Move description into booking, lint Signed-off-by: Aaron Chong <[email protected]> * Pass a clock functor to ParkRobotFactory Signed-off-by: Aaron Chong <[email protected]> * Using non-deprecated Request constructor Signed-off-by: Aaron Chong <[email protected]> * new make_request API to include requester and request time Signed-off-by: Aaron Chong <[email protected]> * Overload TaskPlanner constructor with a name argument Signed-off-by: Aaron Chong <[email protected]> * Retained old API and marked as deprecated Signed-off-by: Aaron Chong <[email protected]> * Overloading booking instead of adding default arguments Signed-off-by: Aaron Chong <[email protected]> * Overloading all affected functions with non optional arguments Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Revert deprecation tag on Request, to be done in a separate PR Signed-off-by: Aaron Chong <[email protected]> * Argument name changes, linting, documentation Signed-off-by: Aaron Chong <[email protected]> * TaskPlanner constructor to have planner id as first argument Signed-off-by: Aaron Chong <[email protected]> * request factories to accept a callback that returns the current time Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit a7875a9) Signed-off-by: Aaron Chong <[email protected]> * Add rmf_task_sequence to workflows, lint (#91) Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 40f3e92) Signed-off-by: Aaron Chong <[email protected]> * Running only humble jammy workflows Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmf_task_sequenceto CI