Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cosine_annealing_lr #25

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Feat/cosine_annealing_lr #25

merged 5 commits into from
Aug 25, 2023

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock commented Aug 24, 2023

fixes #21

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Aug 24, 2023
Copy link
Collaborator

@dae dae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this took a conflict. No problems with the Rust code jump out at me. 👍

src/cosine_annealing.rs Outdated Show resolved Hide resolved
src/cosine_annealing.rs Outdated Show resolved Hide resolved
src/cosine_annealing.rs Outdated Show resolved Hide resolved
@asukaminato0721 asukaminato0721 merged commit 87d11f0 into main Aug 25, 2023
1 check passed
@asukaminato0721 asukaminato0721 deleted the Feat/cosine_annealing_lr branch August 25, 2023 05:18
@asukaminato0721
Copy link
Collaborator

the test seems interesting

---- cosine_annealing::test_lr_scheduler stdout ----
thread 'cosine_annealing::test_lr_scheduler' panicked at 'assertion failed: `(left == right)`
  left: `[0.1, 0.09045084971874769, 0.06545084971874847, 0.03454915028125373, 0.009549150281252953, 0.0, 0.00954915028125269, 0.034549150281252376, 0.0654508497187476, 0.09045084971874953, 0.10000000000000367]`,
 right: `[0.1, 0.09045084971874785, 0.06545084971874875, 0.034549150281253875, 0.009549150281252989, 0.0, 0.009549150281252692, 0.03454915028125239, 0.06545084971874746, 0.09045084971874952, 0.10000000000000353]`', src/cosine_annealing.rs:76:5

maybe need to adjust the precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] feature: CosineAnnealingLR
3 participants