Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move certs helper code from /internal/examples to /internal or /internal/testhelper? #199

Closed
srikanthccv opened this issue Sep 14, 2023 · 1 comment · Fixed by #201
Closed

Comments

@srikanthccv
Copy link
Member

In an effort to improve the test coverage for serverimpl, I started to add some tests with TLS enabled. I noticed we already have some useful code for generating and reading certs in internal/examples/..., and it seems like a good idea to use for tests. I was thinking of moving them to /internal or maybe internal/testhelper and use in both serverimpl tests and examples.

@tigrannajaryan do you see any issues with this? If not, I can send a PR for this along with the new serverimpl TLS tests.

@tigrannajaryan
Copy link
Member

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants