Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move certs & helper code from /internal/examples to /internal #201

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Sep 16, 2023

Fixes #199

I verified that examples run with the changes.

@codecov
Copy link

codecov bot commented Sep 16, 2023

@srikanthccv srikanthccv marked this pull request as ready for review September 17, 2023 04:36
@srikanthccv srikanthccv requested a review from a team September 17, 2023 04:36
internal/certs.go Outdated Show resolved Hide resolved
internal/certs.go Outdated Show resolved Hide resolved
internal/certs.go Outdated Show resolved Hide resolved
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM, just need to confirm that the paths are correct.

internal/examples/agent/agent/agent.go Show resolved Hide resolved
internal/examples/server/opampsrv/opampsrv.go Show resolved Hide resolved
internal/examples/server/uisrv/ui.go Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit b24302d into open-telemetry:main Sep 21, 2023
4 of 6 checks passed
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Nov 28, 2023
#29475)

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/open-telemetry/opamp-go](https://togithub.com/open-telemetry/opamp-go)
| require | minor | `v0.9.0` -> `v0.10.0` |
|
[github.com/open-telemetry/opamp-go](https://togithub.com/open-telemetry/opamp-go)
| require | minor | `v0.8.0` -> `v0.10.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>open-telemetry/opamp-go
(github.com/open-telemetry/opamp-go)</summary>

###
[`v0.10.0`](https://togithub.com/open-telemetry/opamp-go/releases/tag/v0.10.0)

[Compare
Source](https://togithub.com/open-telemetry/opamp-go/compare/v0.9.0...v0.10.0)

##### What's Changed

- Move certs & helper code from /internal/examples to /internal by
[@&#8203;srikanthccv](https://togithub.com/srikanthccv) in
[open-telemetry/opamp-go#201
- Rewind the request body for retries by
[@&#8203;srikanthccv](https://togithub.com/srikanthccv) in
[open-telemetry/opamp-go#194
- Update to OpAMP spec 0.8.0 by
[@&#8203;tigrannajaryan](https://togithub.com/tigrannajaryan) in
[open-telemetry/opamp-go#207

**Full Changelog**:
open-telemetry/opamp-go@v0.9.0...v0.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Signed-off-by: Alex Boten <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move certs helper code from /internal/examples to /internal or /internal/testhelper?
3 participants