Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OpAMP spec 0.8.0 #207

Merged

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Oct 17, 2023

  • Updated the opamp-spec submodule to v0.8.0.
  • Renamed all occurrences of AgentHealth to ComponentHealth. This is a wire-level compatible change but the symbol name has changed and the source code needed to be changed.

- Update the opamp-spec submodule to v0.8.0.
- Renamed all occurrences of AgentHealth to ComponentHealth. This is a wire-level compatible change but the symbol name has changed and the source code needed to be changed.
@tigrannajaryan tigrannajaryan requested a review from a team October 17, 2023 18:06
@tigrannajaryan tigrannajaryan changed the title Update to OpAMP 0.8.0 Update to OpAMP spec 0.8.0 Oct 17, 2023
@tigrannajaryan
Copy link
Member Author

@mwear FYI.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Files Coverage Δ
client/httpclient.go 95.16% <100.00%> (+0.42%) ⬆️
client/internal/clientstate.go 90.47% <100.00%> (ø)
client/internal/receivedprocessor.go 72.60% <100.00%> (-11.69%) ⬇️
client/types/callbacks.go 66.66% <ø> (ø)
client/wsclient.go 91.46% <100.00%> (+6.70%) ⬆️
server/callbacks.go 68.18% <100.00%> (-4.55%) ⬇️
server/serverimpl.go 58.92% <100.00%> (+0.37%) ⬆️
server/wsconnection.go 100.00% <ø> (ø)
client/internal/clientcommon.go 79.80% <75.00%> (ø)
server/httpconnection.go 33.33% <0.00%> (ø)
... and 2 more

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for handling the renames.

Copy link
Contributor

@andykellr andykellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigrannajaryan tigrannajaryan merged commit c1931d7 into open-telemetry:main Oct 17, 2023
5 of 6 checks passed
@tigrannajaryan tigrannajaryan deleted the feature/tigran/update-proto branch October 17, 2023 18:19
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Nov 28, 2023
#29475)

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/open-telemetry/opamp-go](https://togithub.com/open-telemetry/opamp-go)
| require | minor | `v0.9.0` -> `v0.10.0` |
|
[github.com/open-telemetry/opamp-go](https://togithub.com/open-telemetry/opamp-go)
| require | minor | `v0.8.0` -> `v0.10.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>open-telemetry/opamp-go
(github.com/open-telemetry/opamp-go)</summary>

###
[`v0.10.0`](https://togithub.com/open-telemetry/opamp-go/releases/tag/v0.10.0)

[Compare
Source](https://togithub.com/open-telemetry/opamp-go/compare/v0.9.0...v0.10.0)

##### What's Changed

- Move certs & helper code from /internal/examples to /internal by
[@&#8203;srikanthccv](https://togithub.com/srikanthccv) in
[open-telemetry/opamp-go#201
- Rewind the request body for retries by
[@&#8203;srikanthccv](https://togithub.com/srikanthccv) in
[open-telemetry/opamp-go#194
- Update to OpAMP spec 0.8.0 by
[@&#8203;tigrannajaryan](https://togithub.com/tigrannajaryan) in
[open-telemetry/opamp-go#207

**Full Changelog**:
open-telemetry/opamp-go@v0.9.0...v0.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Signed-off-by: Alex Boten <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants