Split connection settings by types #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 78.08% 78.08%
=======================================
Files 22 22
Lines 1720 1720
=======================================
Hits 1343 1343
Misses 283 283
Partials 94 94
Continue to review full report at Codecov.
|
tigrannajaryan
force-pushed
the
feature/tigran/split-con-set
branch
3 times, most recently
from
ddb7283
to
9782f49
Compare
This changes splits connection settings by the type of the connection so that each type has a corresponding message that records the appropriate data. Implements spec change open-telemetry/opamp-spec#87
tigrannajaryan
force-pushed
the
feature/tigran/split-con-set
branch
from
9782f49
to
4e7024d
Compare
pmm-sumo
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes splits connection settings by the type of the connection so that
each type has a corresponding message that records the appropriate data.
Implements spec change open-telemetry/opamp-spec#87