Split connection settings by types #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes splits connection settings by the type of the connection so that each type has a corresponding message that records the appropriate data. See proposal here open-telemetry#80 (comment) I also deleted proxy-related settings since it wasn't clear when and how when can be used. These can be added later when the use case is clear. Contributes to open-telemetry#80
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
May 26, 2022
This changes splits connection settings by the type of the connection so that each type has a corresponding message that records the appropriate data. Implements spec change open-telemetry/opamp-spec#87
pmm-sumo
approved these changes
May 26, 2022
|
I think the change looks good and it clarifies the spec |
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
May 26, 2022
This changes splits connection settings by the type of the connection so that each type has a corresponding message that records the appropriate data. Implements spec change open-telemetry/opamp-spec#87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes splits connection settings by the type of the connection so that
each type has a corresponding message that records the appropriate data.
See proposal here #80 (comment)
I also deleted proxy-related settings since it wasn't clear when and how when
can be used. These can be added later when the use case is clear.
Contributes to #80