Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated 'gke' and 'gce' resource detectors after v0.54.0 is released #10348

Closed
dashpole opened this issue May 25, 2022 · 6 comments · Fixed by #17383
Closed

Remove deprecated 'gke' and 'gce' resource detectors after v0.54.0 is released #10348

dashpole opened this issue May 25, 2022 · 6 comments · Fixed by #17383
Assignees
@dashpole
Labels
admin issues tracker issues etc. comp:google Google Cloud components processor/resourcedetection Resource detection processor

Comments

@dashpole
Copy link
Contributor

dashpole commented May 25, 2022 •
edited
Loading

The replacement is to use the single 'gcp' resource detector. See #10347.
@dashpole dashpole added admin issues tracker issues etc. comp:google Google Cloud components labels May 25, 2022
@dashpole dashpole changed the title Remove deprecated Remove deprecated 'gke' and 'gce' resource detectors after v0.54.0 is released May 25, 2022
@dashpole dashpole self-assigned this May 25, 2022
@dashpole dashpole mentioned this issue May 25, 2022
Merged
@dashpole
Copy link
Contributor Author

This is blocked by #12354. We should avoid removing the old detectors until we can resolve that open issue.

@evan-bradley evan-bradley added the processor/resourcedetection Resource detection processor label Sep 30, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @jrcamp @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 30, 2022
@jpkrohling
Copy link
Member

@jrcamp @Aneurysm9 @dashpole, is this still relevant?

@dashpole
Copy link
Contributor Author

Yes, this is still relevant.

@dashpole dashpole removed the Stale label Nov 30, 2022
codeboten referenced this issue in codeboten/opentelemetry-collector-contrib Jan 4, 2023
bugfix: remove deprecated resource detectors
d2b54d4 
Fixes #10348

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Jan 4, 2023
Merged
codeboten pushed a commit that referenced this issue Jan 4, 2023
bugfix: remove deprecated resource detectors (#17383)
4c860a2 
Fixes #10348

Signed-off-by: Alex Boten <[email protected]>
@sigismund
Copy link

I am not sure if I missed something, but it seems that there is no mention of this in the documentation.

hughesjj added a commit to signalfx/splunk-otel-collector that referenced this issue Jan 18, 2023
@hughesjj
Switch to gcp from gce as specified in open-telemetry/opentelemetry-c…
8d99c1b 
…ollector-contrib#10348
hughesjj added a commit to signalfx/splunk-otel-collector that referenced this issue Jan 18, 2023
@hughesjj
Switch to gcp from gce as specified in open-telemetry/opentelemetry-c…
13c4d8b 
…ollector-contrib#10348

Tracking issue: #2474
hughesjj added a commit to signalfx/splunk-otel-collector that referenced this issue Jan 18, 2023
@hughesjj
Switch to gcp from gce as specified in open-telemetry/opentelemetry-c…
fcbb096 
…ollector-contrib#10348

Tracking issue: #2474
@hughesjj hughesjj mentioned this issue Jan 18, 2023
Merged
hughesjj added a commit to signalfx/splunk-otel-collector that referenced this issue Jan 19, 2023
@hughesjj @atoulme
Switch to gcp from gce/gke (#2488)
e7f0204 
* Switch to gcp from gce as specified in open-telemetry/opentelemetry-collector-contrib#10348
Tracking issue: #2474

* Update cmd/otelcol/config/collector/full_config_linux.yaml

Co-authored-by: Antoine Toulme <[email protected]>

Co-authored-by: Antoine Toulme <[email protected]>
@dashpole dashpole mentioned this issue Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
admin issues tracker issues etc. comp:google Google Cloud components processor/resourcedetection Resource detection processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: remove deprecated resource detectors codeboten/opentelemetry-collector-contrib
4 participants
@jpkrohling @dashpole @sigismund @evan-bradley