[resourcedetection] Unify gke and gce detectors and fix gke zone/region detection #10347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
improve_gcp_detection
branch
2 times, most recently
from
b493486
to
aadd101
Compare
dashpole
force-pushed
the
improve_gcp_detection
branch
from
aadd101
to
ee1600a
Compare
pmm-sumo
reviewed
May 30, 2022
pmm-sumo
reviewed
May 30, 2022
pmm-sumo
approved these changes
May 30, 2022
…one/region detection
dashpole
force-pushed
the
improve_gcp_detection
branch
from
e20aac3
to
d967f07
Compare
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
…on detection (open-telemetry#10347) resourcedetectionprocessor: unify gke and gce detectors and fix gke zone/region detection
This was referenced Jul 13, 2022
This was referenced Jan 18, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…n processor readme (open-telemetry#30665) **Description:** <Describe what has changed.> Some time ago `gce` and `gke` detectors were [deprecated](open-telemetry#10347) to use a single `gcp` detector. This PR updates README to remove mentions of `gce` and `gke` detectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #9682
This is modeled after open-telemetry/opentelemetry-go-contrib#2310, which implements resource detection for the go SDK.
It replaces the
gceandgkedetectors with a singlegcpdetector. This eliminates the need to correctly order the two detectors when running on GKE to get correct behavior. In order to facilitate the migration, i've added warning messages, and ensured that when multiple gcp detectors are used that they are deduplicated.This adds a new dependency: https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/tree/main/detectors/gcp, which is a library for detecting attributes in GCP environments. It is integration tested in real GCP environments.
This adds support for Cloud Run, Cloud Functions (not sure why/how someone would run a collector there, but its possible in theory :)), and App Engine as well.
Removal of 'gke' and 'gce' is tracked in #10348.
Testing:
Unit tests added.
Documentation: