[chore] Fix new lint issues with golangci-lint v1.56.1 #31240

songy23 · 2024-02-13T20:57:13Z

Component(s)

No response

Describe the issue you're reporting

The version upgrade of golangci #31216 surfaced lots of new lint errors, e.g. https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7892240476/job/21538478567?pr=31216. Need to fix these lint errors to unblock #31216.

songy23 · 2024-02-13T20:58:10Z

To reproduce: checkout branch renovate/github.com-golangci-golangci-lint-1.x then run make lint.

This is only a part of the failures, but there's so many i'd rather not submit a single massive PR. Related to #31240 Signed-off-by: Alex Boten <[email protected]>

Related #31240 Signed-off-by: Alex Boten <[email protected]>

crobert-1 · 2024-02-26T20:51:57Z

Removing needs triage as it's been worked on by a project maintainer.

This is only a part of the failures, but there's so many i'd rather not submit a single massive PR. Related to open-telemetry#31240 Signed-off-by: Alex Boten <[email protected]>

Related open-telemetry#31240 Signed-off-by: Alex Boten <[email protected]>

**Description:** linting error with: ``` INFO [runner] linters took 1.336744316s with stages: goanalysis_metalinter: 1.334941582s opentelemetry-collector-contrib/cmd/checkapi/main.go:50:66: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive) err = filepath.Walk(folder, func(path string, info fs.FileInfo, err error) error { ^ ``` and: ``` INFO [runner] linters took 1.806204856s with stages: goanalysis_metalinter: 1.80522593s opentelemetry-collector-contrib/cmd/checkapi/main.go:53:18: shadow: declaration of "err" shadows declaration at line 44 (govet) relativeBase, err := filepath.Rel(folder, base) ^ ``` **Link to tracking Issue:** <Issue number if applicable> - #31240 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

led0nk · 2024-03-25T12:20:16Z

@songy23 i cannot reproduce any other linting errors, so it seems like it's solved for now

songy23 · 2024-03-25T12:34:08Z

There are still linter failures, see https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8341482938/job/22827781178?pr=31830

**Description:** <Describe what has changed.> - Linting Errors: [https://productionresultssa5.blob.core.windows.net/actions-results/44e4093a-f4c1-4e35-af4f-d630ea9b8d68/workflow-job-run-071cf28a-9760-544e-287f-c0f9ae5a03a4/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-25T12%3A45%3A21Z&sig=fRzhKwEpzDQDQZyUYwvEY%2BhkcFWOD3IY0EeCOE47AeU%3D&sp=r&spr=https&sr=b&st=2024-03-25T12%3A35%3A16Z&sv=2021-12-02](url) - some linting errors will be fixed by #30237 **Link to tracking Issue:** <Issue number if applicable> - #31240 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

mx-psi · 2024-03-25T16:32:21Z

One more error to go: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8423315275/job/23064935533

songy23 · 2024-03-25T16:41:58Z

^ the one in opampsupervisor is expected to be fixed in #30237.

led0nk · 2024-03-25T17:00:00Z

^ the one in opampsupervisor is expected to be fixed in #30237.

actually the one won't be fixed through #30237 (as you can see line 243 isn't touched)

There were other one's which would've been obsolete.
Should've seen this one earlier, sorry for that - just opened PR to quickly fix this

**Description:** should be the last one **Link to tracking Issue:** - #31240

led0nk · 2024-03-25T20:06:16Z

@songy23 is there any way to preproduce linting with the updated linter in #31830 ?
with updated upstream-repo i'm not able to reproduce these linting errors...

I think it should be more efficient to run this locally one by one , so we can solve this in a single PR.

songy23 · 2024-03-26T00:43:28Z

@led0nk Looks like I had a typo in my previous comment. You can run make golint after checkout the branch

git checkout renovate/github.com-golangci-golangci-lint-1.x
make golint

The command takes long and you'll need to run it after each fix. Here's what I got with running ^

INFO [runner] linters took 988.335125ms with stages: goanalysis_metalinter: 987.281709ms 
chronyreceiver/factory.go:41:32: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
		scraperhelper.WithStart(func(ctx context.Context, host component.Host) error {
		                             ^

And thanks for helping out here!

**Description:** This PR should solve the related Issue linked below. I tried to switch to blank identifiers instead of removing function arguments, so it could be adapted later on. linting erros in following pkgs: - [x] cmd/configschema - [x] cmd/githubgen - [x] connector/datadogconnector - [x] connector/grafanacloudconnector - [x] connector/servicegraphconnector - [x] exporter/awsemfexporter - [x] exporter/awsxrayexporter - [x] exporter/clickhouseexporter - [x] exporter/datadogexporter - [x] exporter/dynatraceexporter - [x] exporter/elasticsearchexporter - [x] exporter/honeycombmarkerexporter - [x] exporter/influxdbexporter - [x] exporter/instanaexporter - [x] exporter/kafkaexporter - [x] exporter/kineticaexporter - [x] exporter/loadbalancingexporter - [x] exporter/logicmonitorexporter - [x] exporter/logzioexporter - [x] exporter/lokiexporter - [x] exporter/mezmoexporter - [x] exporter/opensearchexporter - [x] exporter/prometheusexporter - [x] exporter/signalfxexporter - [x] exporter/splunkhecexporter - [x] exporter/sumologicexporter - [x] exporter/zipkinexporter - [x] extension/jaegerremotesampling - [x] extension/oauth2clientauthextension - [x] extension/observer - [x] extension/oidcauthextension - [x] extension/sumologicextension - [x] internal/aws - [x] internal/coreinternal - [x] internal/filter - [x] internal/kubelet - [x] internal/metadataproviders - [x] internal/sharedcomponent - [x] pkg/ottl - [x] pkg/pdatautil - [x] pkg/stanza - [x] pkg/translator - [x] processor/deltatocumulativeprocessor - [x] processor/filterprocessor - [x] processor/groupbytraceprocessor - [x] processor/k8sattributesprocessor - [x] processor/logstransformprocessor - [x] processor/metricstransformprocessor - [x] processor/resourcedetectionprocessor - [x] processor/tailsamplingprocessor - [x] processor/transformprocessor - [x] receiver/awscontainerinsightreceiver - [x] receiver/chronyreceiver - [x] receiver/splunkhecreceiver - [x] receiver/sqlqueryreceiver - [x] receiver/vcenterreceiver - [x] receiver/webhookeventreceiver - [x] receiver/zookeeperreceiver **Link to tracking Issue:** - #31240 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>

led0nk · 2024-03-27T17:24:21Z

hopefully this should fix the remaning errors for PR #31830

i don't get any more errors from linting

songy23 · 2024-03-27T17:42:04Z

There are more: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8456126125/job/23165314343?pr=31830

Seems new linter errors introduced in recent PRs :(

led0nk · 2024-03-27T18:23:26Z

Okay i fixed this with recent PRs and no more linting errors on updated renovate-branch.
I hope there are no PRs in the meantime and #31830 won't get any errors.. 🥲

**Description:** quick fix of recent pr with linting error (for updating linter) **Link to tracking Issue:** - #31240 --------- Co-authored-by: Dmitrii Anoshin <[email protected]>

songy23 · 2024-03-27T19:59:54Z

All good, cheers @led0nk

dmitryax · 2024-03-27T20:16:23Z

Thank you, @led0nk!

songy23 added help wanted Extra attention is needed good first issue Good for newcomers needs triage New item requiring triage labels Feb 13, 2024

songy23 mentioned this issue Feb 13, 2024

Update module github.com/golangci/golangci-lint to v1.56.1 #31216

Closed

1 task

codeboten mentioned this issue Feb 15, 2024

[chore] address linting failures #31286

Merged

codeboten pushed a commit that referenced this issue Feb 15, 2024

[chore] address linting failures (#31286)

a7190bb

This is only a part of the failures, but there's so many i'd rather not submit a single massive PR. Related to #31240 Signed-off-by: Alex Boten <[email protected]>

codeboten mentioned this issue Feb 15, 2024

[chore] more lint fixes #31287

Merged

codeboten pushed a commit that referenced this issue Feb 15, 2024

[chore] more lint fixes (#31287)

fee9489

Related #31240 Signed-off-by: Alex Boten <[email protected]>

This was referenced Feb 20, 2024

Weekly Report: 2024-02-13 - 2024-02-20 #31323

Closed

Weekly Report: 2024-02-13 - 2024-02-20 asuresh4/opentelemetry-collector-contrib#11541

Open

crobert-1 added ci-cd CI, CD, testing, build issues and removed needs triage New item requiring triage labels Feb 26, 2024

led0nk added a commit to led0nk/opentelemetry-collector-contrib that referenced this issue Mar 12, 2024

[chore] lint fix (open-telemetry open-telemetry#31240)

4c6534e

led0nk mentioned this issue Mar 12, 2024

[chore] lint fix in cmd/checkapi #31723

Merged

XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024

[chore] more lint fixes (open-telemetry#31287)

1cba6c6

Related open-telemetry#31240 Signed-off-by: Alex Boten <[email protected]>

songy23 mentioned this issue Mar 20, 2024

fix(deps): update module github.com/golangci/golangci-lint to v1.57.1 #31830

Merged

1 task

led0nk mentioned this issue Mar 25, 2024

[chore] lint fixes in cmd/telemetrygen & cmd/opampsupervisor #31932

Merged

mx-psi linked a pull request Mar 25, 2024 that will close this issue

fix(deps): update module github.com/golangci/golangci-lint to v1.57.1 #31830

Merged

1 task

led0nk mentioned this issue Mar 25, 2024

[chore] fix lint in cmd/opampsupervisor #31939

Merged

dmitryax pushed a commit that referenced this issue Mar 25, 2024

[chore] fix lint in cmd/opampsupervisor (#31939)

f8627a7

**Description:** should be the last one **Link to tracking Issue:** - #31240

led0nk mentioned this issue Mar 27, 2024

[chore] fix linting #32004

Merged

58 tasks

songy23 assigned led0nk Mar 27, 2024

led0nk mentioned this issue Mar 27, 2024

[chore] linting fix of recent pr #32006

Merged

dmitryax added a commit that referenced this issue Mar 27, 2024

[chore] linting fix of recent pr (#32006)

fc37902

**Description:** quick fix of recent pr with linting error (for updating linter) **Link to tracking Issue:** - #31240 --------- Co-authored-by: Dmitrii Anoshin <[email protected]>

dmitryax closed this as completed in #31830 Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chore] Fix new lint issues with golangci-lint v1.56.1 #31240

[chore] Fix new lint issues with golangci-lint v1.56.1 #31240

songy23 commented Feb 13, 2024

songy23 commented Feb 13, 2024

crobert-1 commented Feb 26, 2024

led0nk commented Mar 25, 2024

songy23 commented Mar 25, 2024

mx-psi commented Mar 25, 2024

songy23 commented Mar 25, 2024

led0nk commented Mar 25, 2024

led0nk commented Mar 25, 2024 •

edited

Loading

songy23 commented Mar 26, 2024

led0nk commented Mar 27, 2024

songy23 commented Mar 27, 2024

led0nk commented Mar 27, 2024

songy23 commented Mar 27, 2024

dmitryax commented Mar 27, 2024

[chore] Fix new lint issues with golangci-lint v1.56.1 #31240

[chore] Fix new lint issues with golangci-lint v1.56.1 #31240

Comments

songy23 commented Feb 13, 2024

Component(s)

Describe the issue you're reporting

songy23 commented Feb 13, 2024

crobert-1 commented Feb 26, 2024

led0nk commented Mar 25, 2024

songy23 commented Mar 25, 2024

mx-psi commented Mar 25, 2024

songy23 commented Mar 25, 2024

led0nk commented Mar 25, 2024

led0nk commented Mar 25, 2024 • edited Loading

songy23 commented Mar 26, 2024

led0nk commented Mar 27, 2024

songy23 commented Mar 27, 2024

led0nk commented Mar 27, 2024

songy23 commented Mar 27, 2024

dmitryax commented Mar 27, 2024

led0nk commented Mar 25, 2024 •

edited

Loading