Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] lint fix in cmd/checkapi #31723

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

led0nk
Copy link
Contributor

@led0nk led0nk commented Mar 12, 2024

Description:
linting error with:

INFO [runner] linters took 1.336744316s with stages: goanalysis_metalinter: 1.334941582s 
opentelemetry-collector-contrib/cmd/checkapi/main.go:50:66: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
	err = filepath.Walk(folder, func(path string, info fs.FileInfo, err error) error {
	                                                                ^

and:

INFO [runner] linters took 1.806204856s with stages: goanalysis_metalinter: 1.80522593s 
opentelemetry-collector-contrib/cmd/checkapi/main.go:53:18: shadow: declaration of "err" shadows declaration at line 44 (govet)
			relativeBase, err := filepath.Rel(folder, base)
			              ^

Link to tracking Issue:

Testing:

Documentation:

@led0nk led0nk requested review from a team and djaglowski March 12, 2024 21:55
Copy link

linux-foundation-easycla bot commented Mar 12, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@codeboten codeboten merged commit f7f5dbd into open-telemetry:main Mar 13, 2024
143 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 13, 2024
@led0nk led0nk deleted the golangci-lint-fixes branch March 25, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants