-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1/3 Port PDH helpers from Core #1175
1/3 Port PDH helpers from Core #1175
Conversation
e2db281
to
82b7605
Compare
82b7605
to
7d0f544
Compare
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
===========================================
+ Coverage 76.01% 89.97% +13.96%
===========================================
Files 24 283 +259
Lines 1163 13772 +12609
===========================================
+ Hits 884 12391 +11507
- Misses 226 1013 +787
- Partials 53 368 +315
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9b00167
to
673dd9c
Compare
@james-bebbington would it be possible to break into 2 PRs:
|
673dd9c
to
a51e9f3
Compare
a51e9f3
to
2521fb2
Compare
Alright done. I updated this PR & the description so this is now (1) & #1211 is (2) |
2521fb2
to
dbb9d58
Compare
Thank you. |
receiver/windowsperfcountersreceiver/internal/third_party/telegraf/win_perf_counters/LICENSE
Outdated
Show resolved
Hide resolved
…#1211) Adds skeleton for Windows Performance Counters Receiver with very basic initial functionality that can read simple counters that do not include any instance into a Gauge metric - see the added README.md for more details. **Link to tracking Issue:** #1088 Note the scaffolding code makes use of the new `receiverhelper` & `scraperhelper` functions added in the Core PRs referenced below. **Depends on:** #1175, open-telemetry/opentelemetry-collector#1886, open-telemetry/opentelemetry-collector#1890
@james-bebbington made a lot of contributions to the core collector and reviews see https://github.com/open-telemetry/opentelemetry-collector/pulls?q=is%3Apr+author%3Ajames-bebbington+is%3Aclosed+
* Convert XConfigure into constructor for metrics A follow up of #1155. * Add to CHANGELOG Co-authored-by: Tyler Yahn <[email protected]>
Link to tracking Issue: #1088
Description: As a precursor to creating a Windows perf counters receiver component, this PR:
pdh
from Core (was removed from Core in 3/3 Remove third_party PDH code opentelemetry-collector#1870)win_perf_counters
from Core (was removed from Core in 3/3 Remove third_party PDH code opentelemetry-collector#1870)See also: #1211