Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1/3 Port PDH helpers from Core #1175

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Oct 2, 2020

Link to tracking Issue: #1088

Description: As a precursor to creating a Windows perf counters receiver component, this PR:

See also: #1211

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #1175 into master will increase coverage by 13.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1175       +/-   ##
===========================================
+ Coverage   76.01%   89.97%   +13.96%     
===========================================
  Files          24      283      +259     
  Lines        1163    13772    +12609     
===========================================
+ Hits          884    12391    +11507     
- Misses        226     1013      +787     
- Partials       53      368      +315     
Flag Coverage Δ
#integration 76.09% <ø> (+0.08%) ⬆️
#unit 89.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ceiver/awsxrayreceiver/internal/translator/http.go 100.00% <0.00%> (ø)
.../awsxrayreceiver/internal/translator/addtoattrs.go 100.00% <0.00%> (ø)
exporter/signalfxexporter/eventclient.go 89.65% <0.00%> (ø)
receiver/kubeletstatsreceiver/kubelet/volume.go 100.00% <0.00%> (ø)
...fexporter/handler/request_structuredlog_handler.go 100.00% <0.00%> (ø)
exporter/awsemfexporter/emf_exporter.go 97.53% <0.00%> (ø)
...sformprocessor/operation_toggle_scalar_datatype.go 64.28% <0.00%> (ø)
...eiver/awsxrayreceiver/internal/udppoller/poller.go 100.00% <0.00%> (ø)
...edetectionprocessor/resourcedetection_processor.go 90.47% <0.00%> (ø)
receiver/k8sclusterreceiver/receiver.go 100.00% <0.00%> (ø)
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450f782...b47b68c. Read the comment docs.

@james-bebbington james-bebbington force-pushed the windowsperfcounters-receiver branch 2 times, most recently from 9b00167 to 673dd9c Compare October 2, 2020 09:16
@tigrannajaryan
Copy link
Member

@james-bebbington would it be possible to break into 2 PRs:

  1. Copy old (deleted) code as is. We know it was already reviewed so we can merge this without thorough review.
  2. Any changes you need to make. This one we can review more carefully.
    Would that work?

@james-bebbington james-bebbington changed the title Add Windows Performance Counters Receiver skeleton Port third_party PDH helpers from Core Oct 6, 2020
@james-bebbington james-bebbington changed the title Port third_party PDH helpers from Core Port PDH helpers from Core Oct 6, 2020
@james-bebbington james-bebbington changed the title Port PDH helpers from Core 1/2 Port PDH helpers from Core Oct 6, 2020
@james-bebbington
Copy link
Member Author

james-bebbington commented Oct 6, 2020

@james-bebbington would it be possible to break into 2 PRs:

  1. Copy old (deleted) code as is. We know it was already reviewed so we can merge this without thorough review.
  2. Any changes you need to make. This one we can review more carefully.
    Would that work?

Alright done. I updated this PR & the description so this is now (1) & #1211 is (2)

@tigrannajaryan
Copy link
Member

Alright done. I updated this PR & the description so this is now (1) & #1211 is (2)

Thank you.

@james-bebbington james-bebbington changed the title 1/2 Port PDH helpers from Core 1/3 Port PDH helpers from Core Oct 9, 2020
@bogdandrutu bogdandrutu merged commit 2d6c3a4 into open-telemetry:master Oct 12, 2020
tigrannajaryan pushed a commit that referenced this pull request Oct 30, 2020
…#1211)

Adds skeleton for Windows Performance Counters Receiver with very basic initial functionality that can read simple counters that do not include any instance into a Gauge metric - see the added README.md for more details.

**Link to tracking Issue:** #1088

Note the scaffolding code makes use of the new `receiverhelper` & `scraperhelper` functions added in the Core PRs referenced below.

**Depends on:** #1175, open-telemetry/opentelemetry-collector#1886, open-telemetry/opentelemetry-collector#1890
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Convert XConfigure into constructor for metrics

A follow up of #1155.

* Add to CHANGELOG

Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants